[jira] Commented: (CASSANDRA-580) vector clock support

["Jaakko Laine (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12796120#action_12796120 ] 

Jaakko Laine commented on CASSANDRA-580:
----------------------------------------

Read through the patch, following comments/questions: 

(1) Utility methods should be put to FBUtilities 

(2) compareByteSubArrays seems to have following issues: (a) it does not handle the case where bytes2 is null and bytes1 is non-null (b) it does not handle the case where parameter 'length' is bigger than byte array length 

(3) bytes are copied in manual for loops. Is there a reason for not using arraycopy? It would perhaps make the code slightly cleaner and faster (don't know about the latter though, as this involves copying elements within the same array) 

(4) Would it make sense to use some level of data abstraction? Sorting and comparisons always involve copying & handling of individual bytes, which makes the code slightly cumbersome to read, and might be more inefficient than using object references as well (again, not sure about this, have to do some research). 


> vector clock support
> --------------------
>
>                 Key: CASSANDRA-580
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-580
>             Project: Cassandra
>          Issue Type: New Feature
>          Components: Core
>         Environment: N/A
>            Reporter: Kelvin Kakugawa
>            Assignee: Kelvin Kakugawa
>         Attachments: 580-context-v1.patch, 580-context-v2.patch, 580-context-v3.patch, 580-interface-1-add-vector-clock.diff, 580-interface-2-add-vector-clock.diff, 580-thrift-v3.patch, 580-thrift-v4.patch, 580-thrift-v5.patch, 580-thrift-v6.patch
>
>   Original Estimate: 672h
>  Remaining Estimate: 672h
>
> Allow a ColumnFamily to be versioned via vector clocks, instead of long timestamps.  Purpose: enable incr/decr; flexible conflict resolution.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.