You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2021/02/01 14:56:49 UTC
[GitHub] [camel] lburgazzoli opened a new pull request #4986: api: remove createModelFromXml from XMLRoutesDefinitionLoader
lburgazzoli opened a new pull request #4986:
URL: https://github.com/apache/camel/pull/4986
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] If you're unsure, you can format the pull request title like `[CAMEL-XXX] Fixes bug in camel-file component`, where you replace `CAMEL-XXX` with the appropriate JIRA issue.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `mvn clean install -Psourcecheck` in your module with source check enabled to make sure basic checks pass and there are no checkstyle violations. A more thorough check will be performed on your pull request automatically.
Below are the contribution guidelines:
https://github.com/apache/camel/blob/master/CONTRIBUTING.md
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #4986: api: remove createModelFromXml from XMLRoutesDefinitionLoader
Posted by GitBox <gi...@apache.org>.
davsclaus commented on pull request #4986:
URL: https://github.com/apache/camel/pull/4986#issuecomment-771014774
Yeah we never had the strong use-case for createModelFromXml in camel-xml-io. And its not really in use, thought had a public api for end users to load xml files into model classes.
But yeah having it on loader is not the nicest place.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] lburgazzoli edited a comment on pull request #4986: api: remove createModelFromXml from XMLRoutesDefinitionLoader
Posted by GitBox <gi...@apache.org>.
lburgazzoli edited a comment on pull request #4986:
URL: https://github.com/apache/camel/pull/4986#issuecomment-770919098
@davsclaus I've started working on [generic route loader](https://issues.apache.org/jira/browse/CAMEL-15560) and as preliminary work I tried to clean up the XMLRoutesDefinitionLoader APIs, as result I've removed `createModelFromXml` from `XMLRoutesDefinitionLoader` as in fact it is only implemented by `camel-core-jaxb` and it does not look like - at least to me - the method has any relationship with the loader.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] lburgazzoli edited a comment on pull request #4986: api: remove createModelFromXml from XMLRoutesDefinitionLoader
Posted by GitBox <gi...@apache.org>.
lburgazzoli edited a comment on pull request #4986:
URL: https://github.com/apache/camel/pull/4986#issuecomment-770919098
@davsclaus I've started working on [generic route loader](https://issues.apache.org/jira/browse/CAMEL-15560) and as preliminary work I tried to clean up the XMLRoutesDefinitionLoader APIs, as result I've removed `createModelFromXml` from `XMLRoutesDefinitionLoader` as in fact it is only implemented by `camel-core-jaxb` and to me, the method does not seem to have any relationship with the loader.
I have not set the method as deprecated as it looks like it is an internal method people should not use.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus merged pull request #4986: api: remove createModelFromXml from XMLRoutesDefinitionLoader
Posted by GitBox <gi...@apache.org>.
davsclaus merged pull request #4986:
URL: https://github.com/apache/camel/pull/4986
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] lburgazzoli commented on pull request #4986: api: remove createModelFromXml from XMLRoutesDefinitionLoader
Posted by GitBox <gi...@apache.org>.
lburgazzoli commented on pull request #4986:
URL: https://github.com/apache/camel/pull/4986#issuecomment-770919098
@davsclaus I've started working on https://issues.apache.org/jira/browse/CAMEL-15560 and as preliminary work I tried to clean up the XMLRoutesDefinitionLoader APIs, as result I've removed `createModelFromXml` from `XMLRoutesDefinitionLoader` as in fact it is only implemented by `camel-core-jaxb` and it does not look like - at least to me - the method has any relationship with the loader.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] lburgazzoli edited a comment on pull request #4986: api: remove createModelFromXml from XMLRoutesDefinitionLoader
Posted by GitBox <gi...@apache.org>.
lburgazzoli edited a comment on pull request #4986:
URL: https://github.com/apache/camel/pull/4986#issuecomment-770919098
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org