You are viewing a plain text version of this content. The canonical link for it is here.
Posted to log4j-dev@logging.apache.org by ca...@apache.org on 2008/08/12 22:50:29 UTC
svn commit: r685312 - in /logging/log4j/companions/extras/trunk/src:
changes/changes.xml main/java/org/apache/log4j/extras/DOMConfigurator.java
Author: carnold
Date: Tue Aug 12 13:50:29 2008
New Revision: 685312
URL: http://svn.apache.org/viewvc?rev=685312&view=rev
Log:
Bug 44899: Extra NPE error message when using missing appender class with DOMConfigurator
Modified:
logging/log4j/companions/extras/trunk/src/changes/changes.xml
logging/log4j/companions/extras/trunk/src/main/java/org/apache/log4j/extras/DOMConfigurator.java
Modified: logging/log4j/companions/extras/trunk/src/changes/changes.xml
URL: http://svn.apache.org/viewvc/logging/log4j/companions/extras/trunk/src/changes/changes.xml?rev=685312&r1=685311&r2=685312&view=diff
==============================================================================
--- logging/log4j/companions/extras/trunk/src/changes/changes.xml (original)
+++ logging/log4j/companions/extras/trunk/src/changes/changes.xml Tue Aug 12 13:50:29 2008
@@ -22,6 +22,7 @@
<body>
<release version="1.1" date="TBD" description="">
<action action="fix" issue="43312">Mangled source-repository.html</action>
+ <action action="fix" issue="44899">Extra NPE error message when using missing appender class with DOMConfigurator.</action>
</release>
Modified: logging/log4j/companions/extras/trunk/src/main/java/org/apache/log4j/extras/DOMConfigurator.java
URL: http://svn.apache.org/viewvc/logging/log4j/companions/extras/trunk/src/main/java/org/apache/log4j/extras/DOMConfigurator.java?rev=685312&r1=685311&r2=685312&view=diff
==============================================================================
--- logging/log4j/companions/extras/trunk/src/main/java/org/apache/log4j/extras/DOMConfigurator.java (original)
+++ logging/log4j/companions/extras/trunk/src/main/java/org/apache/log4j/extras/DOMConfigurator.java Tue Aug 12 13:50:29 2008
@@ -150,9 +150,11 @@
LogLog.error("No appender named ["+appenderName+"] could be found.");
return null;
} else {
- appender = parseAppender(element);
- appenderBag.put(appenderName, appender);
- return appender;
+ appender = parseAppender(element);
+ if (appender != null) {
+ appenderBag.put(appenderName, appender);
+ }
+ return appender;
}
}
}
---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org