[GitHub] [hbase] johnhomsea commented on a change in pull request #436: HBASE-22699 refactor isMetaClearingException

[GitBox <gi...@apache.org>]

johnhomsea commented on a change in pull request #436: HBASE-22699 refactor isMetaClearingException
URL: https://github.com/apache/hbase/pull/436#discussion_r310373218
 
 

 ##########
 File path: hbase-client/src/main/java/org/apache/hadoop/hbase/exceptions/ClientExceptionsUtil.java
 ##########
 @@ -53,25 +52,22 @@
 
   private ClientExceptionsUtil() {}
 
-  public static boolean isMetaClearingException(Throwable cur) {
-    cur = findException(cur);
+  public static boolean isMetaClearingException(Throwable t) {
+    t = unwrapRemoteException(t);
 
-    if (cur == null) {
+    if (t == null) {
       return true;
     }
-    return !isSpecialException(cur) || (cur instanceof RegionMovedException)
-        || cur instanceof NotServingRegionException;
+    return !regionDefinitelyOnTheRegionServerException(t);
   }
 
-  public static boolean isSpecialException(Throwable cur) {
 
 Review comment:
   I grep the whole project and can't find any other places where the function is called. Maybe removed earlier? Or could you remember in which module? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services