You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Valencia Edna Serrao (Code Review)" <ge...@cloudera.org> on 2018/01/19 11:12:21 UTC
[native-toolchain-CR] IMPALA-6401 : Re-apply the PPC Breakpad patches
Valencia Edna Serrao has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9077
Change subject: IMPALA-6401 : Re-apply the PPC Breakpad patches
......................................................................
IMPALA-6401 : Re-apply the PPC Breakpad patches
This change adds the updated PPC patch for Breakpad
Change-Id: Ia40e6f9a0054b55e72350ddbb96c9ecac53b0419
---
M buildall.sh
A source/breakpad/breakpad-97a98836768f8f0154f8f86e5e14c2bb7e74132e-patches/0002-Build-breakpad-97a98836-on-ppc64le.patch
2 files changed, 475 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/77/9077/1
--
To view, visit http://gerrit.cloudera.org:8080/9077
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia40e6f9a0054b55e72350ddbb96c9ecac53b0419
Gerrit-Change-Number: 9077
Gerrit-PatchSet: 1
Gerrit-Owner: Valencia Edna Serrao <vs...@us.ibm.com>
[native-toolchain-CR] IMPALA-6401 : Re-apply the PPC Breakpad patches
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9077 )
Change subject: IMPALA-6401 : Re-apply the PPC Breakpad patches
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/9077
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia40e6f9a0054b55e72350ddbb96c9ecac53b0419
Gerrit-Change-Number: 9077
Gerrit-PatchSet: 1
Gerrit-Owner: Valencia Edna Serrao <vs...@us.ibm.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Valencia Edna Serrao <vs...@us.ibm.com>
Gerrit-Comment-Date: Mon, 22 Jan 2018 18:48:12 +0000
Gerrit-HasComments: No
[native-toolchain-CR] IMPALA-6401 : Re-apply the PPC Breakpad patches
Posted by "Valencia Edna Serrao (Code Review)" <ge...@cloudera.org>.
Valencia Edna Serrao has posted comments on this change. ( http://gerrit.cloudera.org:8080/9077 )
Change subject: IMPALA-6401 : Re-apply the PPC Breakpad patches
......................................................................
Patch Set 1:
> Thanks for providing an updated patch. Can you briefly describe how
> you tested this?
Thanks for reviewing.
--
To view, visit http://gerrit.cloudera.org:8080/9077
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia40e6f9a0054b55e72350ddbb96c9ecac53b0419
Gerrit-Change-Number: 9077
Gerrit-PatchSet: 1
Gerrit-Owner: Valencia Edna Serrao <vs...@us.ibm.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Valencia Edna Serrao <vs...@us.ibm.com>
Gerrit-Comment-Date: Mon, 22 Jan 2018 11:21:55 +0000
Gerrit-HasComments: No
[native-toolchain-CR] IMPALA-6401 : Re-apply the PPC Breakpad patches
Posted by "Valencia Edna Serrao (Code Review)" <ge...@cloudera.org>.
Valencia Edna Serrao has posted comments on this change. ( http://gerrit.cloudera.org:8080/9077 )
Change subject: IMPALA-6401 : Re-apply the PPC Breakpad patches
......................................................................
Patch Set 1:
> Thanks for providing an updated patch. Can you briefly describe how
> you tested this?
After applying the updated patch on ppc64le the build succeeds but some tests have the same old known issues, which are raised with breakpad community earlier.
On x86, I saw a failure before applying the patch. Short of time to check those details.
--
To view, visit http://gerrit.cloudera.org:8080/9077
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia40e6f9a0054b55e72350ddbb96c9ecac53b0419
Gerrit-Change-Number: 9077
Gerrit-PatchSet: 1
Gerrit-Owner: Valencia Edna Serrao <vs...@us.ibm.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Valencia Edna Serrao <vs...@us.ibm.com>
Gerrit-Comment-Date: Mon, 22 Jan 2018 11:20:59 +0000
Gerrit-HasComments: No
[native-toolchain-CR] IMPALA-6401 : Re-apply the PPC Breakpad patches
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9077 )
Change subject: IMPALA-6401 : Re-apply the PPC Breakpad patches
......................................................................
Patch Set 1:
I ran md5sum on x86 on all binaries with and without the patch and found that the core2md binary has a different checksum. All other binaries match between the builds.
Do you know why that checksum changed? The source doesn't get patched as far as I can see.
--
To view, visit http://gerrit.cloudera.org:8080/9077
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia40e6f9a0054b55e72350ddbb96c9ecac53b0419
Gerrit-Change-Number: 9077
Gerrit-PatchSet: 1
Gerrit-Owner: Valencia Edna Serrao <vs...@us.ibm.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Valencia Edna Serrao <vs...@us.ibm.com>
Gerrit-Comment-Date: Mon, 22 Jan 2018 17:21:22 +0000
Gerrit-HasComments: No
[native-toolchain-CR] IMPALA-6401 : Re-apply the PPC Breakpad patches
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9077 )
Change subject: IMPALA-6401 : Re-apply the PPC Breakpad patches
......................................................................
Patch Set 1:
Thanks for providing an updated patch. Can you briefly describe how you tested this?
--
To view, visit http://gerrit.cloudera.org:8080/9077
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia40e6f9a0054b55e72350ddbb96c9ecac53b0419
Gerrit-Change-Number: 9077
Gerrit-PatchSet: 1
Gerrit-Owner: Valencia Edna Serrao <vs...@us.ibm.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Comment-Date: Fri, 19 Jan 2018 20:37:11 +0000
Gerrit-HasComments: No
[native-toolchain-CR] IMPALA-6401 : Re-apply the PPC Breakpad patches
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9077 )
Change subject: IMPALA-6401 : Re-apply the PPC Breakpad patches
......................................................................
Patch Set 1: Code-Review+2
After poking around this for a bit longer I convinced myself that the checksum difference must have been caused by #ifdef related whitespace changes in conjunction with gcc's -g flag.
--
To view, visit http://gerrit.cloudera.org:8080/9077
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia40e6f9a0054b55e72350ddbb96c9ecac53b0419
Gerrit-Change-Number: 9077
Gerrit-PatchSet: 1
Gerrit-Owner: Valencia Edna Serrao <vs...@us.ibm.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Valencia Edna Serrao <vs...@us.ibm.com>
Gerrit-Comment-Date: Mon, 22 Jan 2018 18:48:04 +0000
Gerrit-HasComments: No
[native-toolchain-CR] IMPALA-6401 : Re-apply the PPC Breakpad patches
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9077 )
Change subject: IMPALA-6401 : Re-apply the PPC Breakpad patches
......................................................................
IMPALA-6401 : Re-apply the PPC Breakpad patches
This change adds the updated PPC patch for Breakpad
Change-Id: Ia40e6f9a0054b55e72350ddbb96c9ecac53b0419
---
M buildall.sh
A source/breakpad/breakpad-97a98836768f8f0154f8f86e5e14c2bb7e74132e-patches/0002-Build-breakpad-97a98836-on-ppc64le.patch
2 files changed, 475 insertions(+), 1 deletion(-)
Approvals:
Lars Volker: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/9077
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia40e6f9a0054b55e72350ddbb96c9ecac53b0419
Gerrit-Change-Number: 9077
Gerrit-PatchSet: 1
Gerrit-Owner: Valencia Edna Serrao <vs...@us.ibm.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Valencia Edna Serrao <vs...@us.ibm.com>
[native-toolchain-CR] IMPALA-6401 : Re-apply the PPC Breakpad patches
Posted by "Valencia Edna Serrao (Code Review)" <ge...@cloudera.org>.
Valencia Edna Serrao has posted comments on this change. ( http://gerrit.cloudera.org:8080/9077 )
Change subject: IMPALA-6401 : Re-apply the PPC Breakpad patches
......................................................................
Patch Set 1:
> Change has been successfully merged by Lars Volker
Thanks, Lars!
--
To view, visit http://gerrit.cloudera.org:8080/9077
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia40e6f9a0054b55e72350ddbb96c9ecac53b0419
Gerrit-Change-Number: 9077
Gerrit-PatchSet: 1
Gerrit-Owner: Valencia Edna Serrao <vs...@us.ibm.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Valencia Edna Serrao <vs...@us.ibm.com>
Gerrit-Comment-Date: Tue, 23 Jan 2018 04:24:02 +0000
Gerrit-HasComments: No