[jira] [Commented] (AIRFLOW-6800) SSHHook: Close file object when reading ssh config

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AIRFLOW-6800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17036617#comment-17036617 ] 

ASF GitHub Bot commented on AIRFLOW-6800:
-----------------------------------------

yuqian90 commented on pull request #7415: [AIRFLOW-6800] Close file object after parsing ssh config
URL: https://github.com/apache/airflow/pull/7415
 
 
   This line of code in ssh/hooks.py is opening a file object without closing it in the scope where it is opened.
   This causes unnecessary noise e.g. when py.test warns about unclosed file objects. This PR fixes it by making sure file object is closed properly.
    
   ---
   Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)
   
   Make sure to mark the boxes below before creating PR: [x]
   
   - [x ] Description above provides context of the change
   - [x] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN = JIRA ID<sup>*</sup>
   - [x ] Unit tests coverage for changes (not needed for documentation changes)
   - [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
   - [x] Relevant documentation is updated including usage instructions.
   - [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
   
   <sup>*</sup> For document-only changes commit message can start with `[AIRFLOW-XXXX]`.
   
   ---
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> SSHHook: Close file object when reading ssh config
> --------------------------------------------------
>
>                 Key: AIRFLOW-6800
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-6800
>             Project: Apache Airflow
>          Issue Type: Improvement
>          Components: hooks
>    Affects Versions: 1.10.9
>            Reporter: Qian Yu
>            Assignee: Qian Yu
>            Priority: Trivial
>
> This line of code in ssh/hooks.py is opening a file object without closing it in the scope where it is opened.
> This causes unnecessary noise e.g. when py.test warns about unclosed file objects:
> {code}
> ResourceWarning: unclosed file <_io.TextIOWrapper name='/home/test/.ssh/config' mode='r' encoding='UTF-8'>
> Exception ignored in: <_io.FileIO name='/home/test/.ssh/config' mode='rb' closefd=True>
> {code}
> Using context manager fixes this easily.
> {code}
>             ssh_conf = paramiko.SSHConfig()
>             ssh_conf.parse(open(user_ssh_config_filename))
>             host_info = ssh_conf.lookup(self.remote_host)
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)