You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Jonathan Hurley <jh...@hortonworks.com> on 2015/02/17 18:02:46 UTC
Review Request 31119: Ranger Prevents HDFS NameNode From Restarting
Due To Malformed File Location
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31119/
-----------------------------------------------------------
Review request for Ambari, Nate Cole and Tom Beerbower.
Bugs: AMBARI-9677
https://issues.apache.org/jira/browse/AMBARI-9677
Repository: ambari
Description
-------
When restarting NameNode with Ranger enabled, an exception is thrown because the path to install.properties is malformed.
It appears as though the path to {{install.properties}} is parsed from non-structured output and could include a newline.
Diffs
-----
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/setup_ranger_hbase.py 97706f8
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/setup_ranger_hdfs.py a99a005
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/setup_ranger_hive.py acaead3
ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/setup_ranger_knox.py 09e9325
ambari-server/src/main/resources/common-services/RANGER/0.4.0/configuration/ranger-env.xml be3b06f
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py 271b038
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger.py 54ad72e
ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/setup_ranger_storm.py 9e687c8
ambari-server/src/test/python/stacks/2.0.6/HDFS/test_namenode.py c60e8a0
ambari-server/src/test/python/stacks/2.0.6/configs/ranger-namenode-start.json PRE-CREATION
Diff: https://reviews.apache.org/r/31119/diff/
Testing
-------
Verified fixes in broken environment; added new test case to ensure that is_file throws a Fail.
----------------------------------------------------------------------
Total run:595
Total errors:0
Total failures:0
OK
Thanks,
Jonathan Hurley
Re: Review Request 31119: Ranger Prevents HDFS NameNode From
Restarting Due To Malformed File Location
Posted by Jonathan Hurley <jh...@hortonworks.com>.
> On Feb. 17, 2015, 12:32 p.m., Nate Cole wrote:
> > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/setup_ranger_hbase.py, lines 60-61
> > <https://reviews.apache.org/r/31119/diff/1/?file=866370#file866370line60>
> >
> > If it doesn't exist to start with, do you need to create it?
Not according to the Ranger team. That file is placed there through some Ranger-esque magic and needs to exist. I believe it's part of the plugin install.
- Jonathan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31119/#review72732
-----------------------------------------------------------
On Feb. 17, 2015, 12:02 p.m., Jonathan Hurley wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31119/
> -----------------------------------------------------------
>
> (Updated Feb. 17, 2015, 12:02 p.m.)
>
>
> Review request for Ambari, Nate Cole and Tom Beerbower.
>
>
> Bugs: AMBARI-9677
> https://issues.apache.org/jira/browse/AMBARI-9677
>
>
> Repository: ambari
>
>
> Description
> -------
>
> When restarting NameNode with Ranger enabled, an exception is thrown because the path to install.properties is malformed.
>
> It appears as though the path to {{install.properties}} is parsed from non-structured output and could include a newline.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/setup_ranger_hbase.py 97706f8
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/setup_ranger_hdfs.py a99a005
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/setup_ranger_hive.py acaead3
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/setup_ranger_knox.py 09e9325
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/configuration/ranger-env.xml be3b06f
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py 271b038
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger.py 54ad72e
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/setup_ranger_storm.py 9e687c8
> ambari-server/src/test/python/stacks/2.0.6/HDFS/test_namenode.py c60e8a0
> ambari-server/src/test/python/stacks/2.0.6/configs/ranger-namenode-start.json PRE-CREATION
>
> Diff: https://reviews.apache.org/r/31119/diff/
>
>
> Testing
> -------
>
> Verified fixes in broken environment; added new test case to ensure that is_file throws a Fail.
>
> ----------------------------------------------------------------------
> Total run:595
> Total errors:0
> Total failures:0
> OK
>
>
> Thanks,
>
> Jonathan Hurley
>
>
Re: Review Request 31119: Ranger Prevents HDFS NameNode From
Restarting Due To Malformed File Location
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31119/#review72732
-----------------------------------------------------------
Ship it!
In general, the pattern of Fail-on-exist is in the patch. Just wanted to confirm that you don't need to create if it doesn't exist at all. Other than that, +1.
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/setup_ranger_hbase.py
<https://reviews.apache.org/r/31119/#comment118791>
If it doesn't exist to start with, do you need to create it?
- Nate Cole
On Feb. 17, 2015, 12:02 p.m., Jonathan Hurley wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31119/
> -----------------------------------------------------------
>
> (Updated Feb. 17, 2015, 12:02 p.m.)
>
>
> Review request for Ambari, Nate Cole and Tom Beerbower.
>
>
> Bugs: AMBARI-9677
> https://issues.apache.org/jira/browse/AMBARI-9677
>
>
> Repository: ambari
>
>
> Description
> -------
>
> When restarting NameNode with Ranger enabled, an exception is thrown because the path to install.properties is malformed.
>
> It appears as though the path to {{install.properties}} is parsed from non-structured output and could include a newline.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/setup_ranger_hbase.py 97706f8
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/setup_ranger_hdfs.py a99a005
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/setup_ranger_hive.py acaead3
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/setup_ranger_knox.py 09e9325
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/configuration/ranger-env.xml be3b06f
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py 271b038
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger.py 54ad72e
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/setup_ranger_storm.py 9e687c8
> ambari-server/src/test/python/stacks/2.0.6/HDFS/test_namenode.py c60e8a0
> ambari-server/src/test/python/stacks/2.0.6/configs/ranger-namenode-start.json PRE-CREATION
>
> Diff: https://reviews.apache.org/r/31119/diff/
>
>
> Testing
> -------
>
> Verified fixes in broken environment; added new test case to ensure that is_file throws a Fail.
>
> ----------------------------------------------------------------------
> Total run:595
> Total errors:0
> Total failures:0
> OK
>
>
> Thanks,
>
> Jonathan Hurley
>
>
Re: Review Request 31119: Ranger Prevents HDFS NameNode From
Restarting Due To Malformed File Location
Posted by Tom Beerbower <tb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31119/#review72734
-----------------------------------------------------------
Ship it!
Ship It!
- Tom Beerbower
On Feb. 17, 2015, 5:02 p.m., Jonathan Hurley wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31119/
> -----------------------------------------------------------
>
> (Updated Feb. 17, 2015, 5:02 p.m.)
>
>
> Review request for Ambari, Nate Cole and Tom Beerbower.
>
>
> Bugs: AMBARI-9677
> https://issues.apache.org/jira/browse/AMBARI-9677
>
>
> Repository: ambari
>
>
> Description
> -------
>
> When restarting NameNode with Ranger enabled, an exception is thrown because the path to install.properties is malformed.
>
> It appears as though the path to {{install.properties}} is parsed from non-structured output and could include a newline.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/setup_ranger_hbase.py 97706f8
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/setup_ranger_hdfs.py a99a005
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/setup_ranger_hive.py acaead3
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/setup_ranger_knox.py 09e9325
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/configuration/ranger-env.xml be3b06f
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py 271b038
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger.py 54ad72e
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/setup_ranger_storm.py 9e687c8
> ambari-server/src/test/python/stacks/2.0.6/HDFS/test_namenode.py c60e8a0
> ambari-server/src/test/python/stacks/2.0.6/configs/ranger-namenode-start.json PRE-CREATION
>
> Diff: https://reviews.apache.org/r/31119/diff/
>
>
> Testing
> -------
>
> Verified fixes in broken environment; added new test case to ensure that is_file throws a Fail.
>
> ----------------------------------------------------------------------
> Total run:595
> Total errors:0
> Total failures:0
> OK
>
>
> Thanks,
>
> Jonathan Hurley
>
>