You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by GitBox <gi...@apache.org> on 2019/01/21 10:46:02 UTC
[GitHub] shardul-cr7 commented on a change in pull request #3083:
[CARBONDATA-3257] Fix for NO_SORT load and describe formatted being in
NO_SORT flow even with Sort Columns given
shardul-cr7 commented on a change in pull request #3083: [CARBONDATA-3257] Fix for NO_SORT load and describe formatted being in NO_SORT flow even with Sort Columns given
URL: https://github.com/apache/carbondata/pull/3083#discussion_r249401416
##########
File path: core/src/main/java/org/apache/carbondata/core/metadata/schema/table/CarbonTable.java
##########
@@ -1347,12 +1346,9 @@ public static boolean hasMVDataMap(CarbonTable carbonTable) throws IOException {
if (getNumberOfSortColumns() == 0) {
return SortScopeOptions.SortScope.NO_SORT;
} else {
- return SortScopeOptions.getSortScope(
- CarbonProperties.getInstance().getProperty(
- CarbonLoadOptionConstants.CARBON_OPTIONS_SORT_SCOPE,
- CarbonProperties.getInstance().getProperty(
- CarbonCommonConstants.LOAD_SORT_SCOPE,
- CarbonCommonConstants.LOAD_SORT_SCOPE_DEFAULT)));
+ return SortScopeOptions.getSortScope(CarbonProperties.getInstance()
+ .getProperty("carbon.load.sort.scope",
Review comment:
Use LOAD_SORT_SCOPE here instead of "carbon.load.sort.scope"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services