You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "abhioncbr (via GitHub)" <gi...@apache.org> on 2023/07/06 23:56:54 UTC

[GitHub] [pinot] abhioncbr commented on a diff in pull request #11052: [multistage] support physical plan in Explain queries

abhioncbr commented on code in PR #11052:
URL: https://github.com/apache/pinot/pull/11052#discussion_r1255038721


##########
pinot-query-planner/src/test/java/org/apache/pinot/query/QueryEnvironmentTestBase.java:
##########
@@ -202,4 +205,10 @@ public String toString() {
       }
     }
   }
+
+  // temporary function to strip the Physical plan from the explain query plan.
+  // physical plan is present for the explain queries by default.

Review Comment:
   Added this temporary function to strip the physical plan from the output. 
   
   @walterddr question, do we want physical and logical plans per the default Calcite default implementation, or do we want to change it? I will remove this temp function based on the feedback.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org