You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Sushil Mohanty <su...@gmail.com> on 2015/06/10 12:43:46 UTC
Review Request 35293: LENS-599: Include only fact subqueries to
filter fact records in columnar rewriter
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35293/
-----------------------------------------------------------
Review request for lens and Amareshwari Sriramadasu.
Bugs: LENS-599
https://issues.apache.org/jira/browse/LENS-599
Repository: lens
Description
-------
Currently subqueries other than fact columns are being added to main fact subquery to filter out fact records. Ideally it should use only fact columns.
Diffs
-----
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java 51a06c4
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java dc30bb9
Diff: https://reviews.apache.org/r/35293/diff/
Testing
-------
Added a unit test. All unit tests are running fine.
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [3.077s]
[INFO] Lens .............................................. SUCCESS [0.238s]
[INFO] Lens API .......................................... SUCCESS [13.550s]
[INFO] Lens API for server and extensions ................ SUCCESS [32.727s]
[INFO] Lens Cube ......................................... SUCCESS [4:06.982s]
[INFO] Lens DB storage ................................... SUCCESS [21.061s]
[INFO] Lens Query Library ................................ SUCCESS [10.611s]
[INFO] Lens Hive Driver .................................. SUCCESS [4:06.219s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [30.731s]
[INFO] Lens Server ....................................... SUCCESS [14:26.370s]
[INFO] Lens client ....................................... SUCCESS [37.714s]
[INFO] Lens CLI .......................................... SUCCESS [4:59.611s]
[INFO] Lens Examples ..................................... SUCCESS [4.998s]
[INFO] Lens Distribution ................................. SUCCESS [3.272s]
[INFO] Lens ML Lib ....................................... SUCCESS [2:27.637s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [8.845s]
[INFO] Lens Regression ................................... SUCCESS [0.934s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 32:55.695s
[INFO] Finished at: Wed Jun 10 15:57:15 IST 2015
[INFO] Final Memory: 137M/1085M
[INFO] ------------------------------------------------------------------------
Thanks,
Sushil Mohanty
Re: Review Request 35293: LENS-599: Include only fact subqueries to
filter fact records in columnar rewriter
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35293/#review87526
-----------------------------------------------------------
Ship it!
Ship It!
- Amareshwari Sriramadasu
On June 10, 2015, 10:43 a.m., Sushil Mohanty wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35293/
> -----------------------------------------------------------
>
> (Updated June 10, 2015, 10:43 a.m.)
>
>
> Review request for lens and Amareshwari Sriramadasu.
>
>
> Bugs: LENS-599
> https://issues.apache.org/jira/browse/LENS-599
>
>
> Repository: lens
>
>
> Description
> -------
>
> Currently subqueries other than fact columns are being added to main fact subquery to filter out fact records. Ideally it should use only fact columns.
>
>
> Diffs
> -----
>
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java 51a06c4
> lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java dc30bb9
>
> Diff: https://reviews.apache.org/r/35293/diff/
>
>
> Testing
> -------
>
> Added a unit test. All unit tests are running fine.
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [3.077s]
> [INFO] Lens .............................................. SUCCESS [0.238s]
> [INFO] Lens API .......................................... SUCCESS [13.550s]
> [INFO] Lens API for server and extensions ................ SUCCESS [32.727s]
> [INFO] Lens Cube ......................................... SUCCESS [4:06.982s]
> [INFO] Lens DB storage ................................... SUCCESS [21.061s]
> [INFO] Lens Query Library ................................ SUCCESS [10.611s]
> [INFO] Lens Hive Driver .................................. SUCCESS [4:06.219s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [30.731s]
> [INFO] Lens Server ....................................... SUCCESS [14:26.370s]
> [INFO] Lens client ....................................... SUCCESS [37.714s]
> [INFO] Lens CLI .......................................... SUCCESS [4:59.611s]
> [INFO] Lens Examples ..................................... SUCCESS [4.998s]
> [INFO] Lens Distribution ................................. SUCCESS [3.272s]
> [INFO] Lens ML Lib ....................................... SUCCESS [2:27.637s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [8.845s]
> [INFO] Lens Regression ................................... SUCCESS [0.934s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 32:55.695s
> [INFO] Finished at: Wed Jun 10 15:57:15 IST 2015
> [INFO] Final Memory: 137M/1085M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Sushil Mohanty
>
>