You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@spark.apache.org by "morvenhuang (Jira)" <ji...@apache.org> on 2022/03/24 02:36:00 UTC

[jira] [Created] (SPARK-38641) Get rid of invalid configuration elements in mvn_scalafmt in main pom.xml

morvenhuang created SPARK-38641:
-----------------------------------

             Summary: Get rid of invalid configuration elements in mvn_scalafmt in main pom.xml
                 Key: SPARK-38641
                 URL: https://issues.apache.org/jira/browse/SPARK-38641
             Project: Spark
          Issue Type: Improvement
          Components: Build
    Affects Versions: 3.2.1
            Reporter: morvenhuang


After loading latest spark code into IntelliJ IDEA, it complains that configuration 'parameters' and 'skip' under mvn_scalafmt plugin are not allowed, see screenshot attached for details. 

 

I've contacted the author of mvn_scalafmt, Ciaran Kearney, to confirm if these 2 configuration items are no longer there since v 1.0.0, here's his return, 

 
{quote}That's correct.  The command line parameters were removed by scalafmt itself a few versions ago and skip was replaced by validateOnly (which checks formatting without changing files.
{quote}
 

I think we should get rid of the 'parameters' since it's invalid , and replace 'skip' with 'validateOnly' as Ciaran said.

 

I can make a quick fix for this.

 



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org