You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@parquet.apache.org by GitBox <gi...@apache.org> on 2022/08/22 15:36:21 UTC

[GitHub] [parquet-mr] steveloughran commented on a diff in pull request #985: PARQUET-2173. Fix parquet build against hadoop 3.3.3+

steveloughran commented on code in PR #985:
URL: https://github.com/apache/parquet-mr/pull/985#discussion_r951589888


##########
pom.xml:
##########
@@ -160,7 +160,11 @@
         <exclusions>
           <exclusion>
             <groupId>org.slf4j</groupId>
-            <artifactId>slf4j-log4j12</artifactId>
+            <artifactId>*</artifactId>

Review Comment:
   it means that 
   1. classic log4j is excluded
   2. slf4j-reload4j is excluded
   3. when the hadoop move to log4j2 is finally shipped, its slf4j bindings will be excluded too.
   
   exclusions 1 and 2 could be done explicitly, but #3 is unclear until something ships. (hadoop trunk/3.4 is on log4j2, but the move isn't complete)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@parquet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org