You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@orc.apache.org by GitBox <gi...@apache.org> on 2022/05/26 17:37:11 UTC
[GitHub] [orc] mwlon opened a new pull request, #1143: Catch ServiceConfigurationErrors
mwlon opened a new pull request, #1143:
URL: https://github.com/apache/orc/pull/1143
### What changes were proposed in this pull request?
Allow running benchmarks even if irrelevant benchmarks are misconfigured
### Why are the changes needed?
Handling `java.util.ServiceConfigurationError` in the main Driver loop on benchmark initialization
### How was this patch tested?
This does not affect main ORC or tests, only the benchmark suite. I tested by packaging and running `java -jar hive/target/orc-benchmarks-hive-1.9.0-SNAPSHOT-uber.jar read-all data`, observing that it no longer threw a `ServiceConfigurationError` on `ORCWriterBenchMark`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #1143: ORC-1190: Catch ServiceConfigurationErrors
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on PR #1143:
URL: https://github.com/apache/orc/pull/1143#issuecomment-1138901226
BTW, FYI, we are trying to add a test coverage for benchmark. Here is the AS-IS progress. We can add your bug report here.
https://github.com/apache/orc/blob/dc2d86487e6e4479e8d674e64a851dd1a8da74aa/java/CMakeLists.txt#L79-L92
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] mwlon commented on pull request #1143: ORC-1190: Fix Writer benchmark initialization
Posted by GitBox <gi...@apache.org>.
mwlon commented on PR #1143:
URL: https://github.com/apache/orc/pull/1143#issuecomment-1139078919
@dongjoon-hyun done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #1143: ORC-1190: Fix Writer benchmark initialization
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on PR #1143:
URL: https://github.com/apache/orc/pull/1143#issuecomment-1139081060
BTW, it would be better if you narrow down more into `dumpDir`. The current title is too broad. :)
```
Fix Writer benchmark initialization
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #1143: ORC-1190: Catch ServiceConfigurationErrors
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on PR #1143:
URL: https://github.com/apache/orc/pull/1143#issuecomment-1138892354
I agree with your user perspective. However, I prefer to push the community fix it immediately because we are the developers. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] mwlon commented on pull request #1143: ORC-1190: Catch ServiceConfigurationErrors
Posted by GitBox <gi...@apache.org>.
mwlon commented on PR #1143:
URL: https://github.com/apache/orc/pull/1143#issuecomment-1138890773
@dongjoon-hyun I agree we should have an early exception if the _intended_ benchmark is misconfigured, but shouldn't we be able to run a benchmark individually as long as it is correctly configured?
Right now I can't run any of the benchmarks - you can verify this behavior. For instance, trying to run the `"read-all"` benchmark fails simply because we can't initialize the irrelevant writer one to check if its name is equal to `"read-all"`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #1143: ORC-1190: Fix Writer benchmark initialization
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on PR #1143:
URL: https://github.com/apache/orc/pull/1143#issuecomment-1139080273
Thank you for updating. Let me verify manually in this evening.
Since we don't have a test coverage in our CI, this should be tested manually.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun closed pull request #1143: ORC-1190: Fix `ORCWriterBenchMark` `dumpDir` initialization
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #1143: ORC-1190: Fix `ORCWriterBenchMark` `dumpDir` initialization
URL: https://github.com/apache/orc/pull/1143
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #1143: ORC-1190: Fix Writer benchmark initialization
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on PR #1143:
URL: https://github.com/apache/orc/pull/1143#issuecomment-1139304168
BTW, cc @autumnust and @pgaref , too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #1143: ORC-1190: Fix `ORCWriterBenchMark` `dumpDir` initialization
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on PR #1143:
URL: https://github.com/apache/orc/pull/1143#issuecomment-1139715816
Merged to main/1.8/1.7.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] mwlon commented on pull request #1143: ORC-1190: Catch ServiceConfigurationErrors
Posted by GitBox <gi...@apache.org>.
mwlon commented on PR #1143:
URL: https://github.com/apache/orc/pull/1143#issuecomment-1138928762
@dongjoon-hyun Do you prefer this solution?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org