You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Samuel Martin (JIRA)" <ji...@apache.org> on 2018/03/31 20:11:00 UTC
[jira] [Updated] (CSV-223) Inconsistency between Javadoc of
CSVFormat DEFAULT EXCEL
[ https://issues.apache.org/jira/browse/CSV-223?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Samuel Martin updated CSV-223:
------------------------------
Description:
According to the [Javadoc of CSVFormat|https://commons.apache.org/proper/commons-csv/archives/1.5/apidocs/index.html]
* {{CSVFormat.DEFAULT}} includes among its settings {{withIgnoreEmptyLines(true)}}
* {{CSVFormat.EXCEL}} includes among its settings {{withIgnoreEmptyLines(false)}}
* Then, the same documentation of {{CSVFormat.EXCEL}} reads that
{quote}Note: this is currently like RFC4180 plus withAllowMissingColumnNames(true).{quote}
One of these three must be wrong (both ignore empty lines, or neither ignores empty lines, or there is another difference that needs to be mentioned).
Edit: after checking the source code, I conclude that the latest sentence is incomplete, and should also mention {{withIgnoreEmptyLines(false)}} as a difference with {{DEFAULT}}
was:
According to the [Javadoc of CSVFormat|https://commons.apache.org/proper/commons-csv/archives/1.5/apidocs/index.html]
* {{CSVFormat.DEFAULT}} includes among its settings {{withIgnoreEmptyLines(true)}}
* {{CSVFormat.EXCEL}} includes among its settings {{withIgnoreEmptyLines(false)}}
* Then, the same documentation of {{CSVFormat.EXCEL}} reads that
{quote}Note: this is currently like RFC4180 plus withAllowMissingColumnNames(true).{quote}
One of these three must be wrong (both ignore empty lines, or neither ignores empty lines, or there is another difference that needs to be mentioned).
> Inconsistency between Javadoc of CSVFormat DEFAULT EXCEL
> ---------------------------------------------------------
>
> Key: CSV-223
> URL: https://issues.apache.org/jira/browse/CSV-223
> Project: Commons CSV
> Issue Type: Bug
> Components: Documentation
> Reporter: Samuel Martin
> Priority: Minor
>
> According to the [Javadoc of CSVFormat|https://commons.apache.org/proper/commons-csv/archives/1.5/apidocs/index.html]
> * {{CSVFormat.DEFAULT}} includes among its settings {{withIgnoreEmptyLines(true)}}
> * {{CSVFormat.EXCEL}} includes among its settings {{withIgnoreEmptyLines(false)}}
> * Then, the same documentation of {{CSVFormat.EXCEL}} reads that
> {quote}Note: this is currently like RFC4180 plus withAllowMissingColumnNames(true).{quote}
> One of these three must be wrong (both ignore empty lines, or neither ignores empty lines, or there is another difference that needs to be mentioned).
> Edit: after checking the source code, I conclude that the latest sentence is incomplete, and should also mention {{withIgnoreEmptyLines(false)}} as a difference with {{DEFAULT}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)