[GitHub] [hive] ayushtkn commented on a diff in pull request #4082: HIVE-27105: Parquet and kafka-client both use zstd-jni. Upgrading kaf…

["ayushtkn (via GitHub)" <gi...@apache.org>]

ayushtkn commented on code in PR #4082:
URL: https://github.com/apache/hive/pull/4082#discussion_r1118373976


##########
kafka-handler/src/java/org/apache/hadoop/hive/kafka/KafkaStorageHandler.java:
##########
@@ -310,7 +311,7 @@ private String getQueryId() {
 
     RetryUtils.CleanupAfterFailure cleanUpTheMap = new RetryUtils.CleanupAfterFailure() {
       @Override public void cleanup() {
-        producersMap.forEach((s, producer) -> producer.close(0, TimeUnit.MILLISECONDS));
+        producersMap.forEach((s, producer) -> producer.close(Duration.ofMillis(TimeUnit.MILLISECONDS.toMillis(0))));

Review Comment:
   Why not directly do ``Duration.ofMillis(0))``
   Something like this
   ```
           producersMap.forEach((s, producer) -> producer.close(Duration.ofMillis(0)));
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org