You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2020/09/22 08:23:26 UTC
[GitHub] [lucene-solr] iverase opened a new pull request #1907: LUCENE-9538: Detect polygon self-intersections in the Tessellator
iverase opened a new pull request #1907:
URL: https://github.com/apache/lucene-solr/pull/1907
This PR adds a check in the tessellator to detect self-intersections so it can provide a more meaningful error to the user.
cc: @nknize
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] iverase closed pull request #1907: LUCENE-9538: Detect polygon self-intersections in the Tessellator
Posted by GitBox <gi...@apache.org>.
iverase closed pull request #1907:
URL: https://github.com/apache/lucene-solr/pull/1907
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] iverase commented on pull request #1907: LUCENE-9538: Detect polygon self-intersections in the Tessellator
Posted by GitBox <gi...@apache.org>.
iverase commented on pull request #1907:
URL: https://github.com/apache/lucene-solr/pull/1907#issuecomment-707042029
Thinking more about this, I am not sure if we can make it optional. There can be situations when the polygon is invalid but it actually does not fail when it is tessellated. We have an example in the tests, where the polygon looks like:
<img width="400" alt="image" src="https://user-images.githubusercontent.com/29038686/95737373-d8105780-0c87-11eb-9f1f-3bd16e392067.png">
This polygon is invalid and the new check will throw an error but it does not fail if you try to tessellate it. The documentation of the 'Tessellator` explicitly says that:
```
Holes may only touch at one vertex
```
IMHO I think we should fail in this case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] iverase commented on pull request #1907: LUCENE-9538: Detect polygon self-intersections in the Tessellator
Posted by GitBox <gi...@apache.org>.
iverase commented on pull request #1907:
URL: https://github.com/apache/lucene-solr/pull/1907#issuecomment-960913522
superseded by https://github.com/apache/lucene/pull/428
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] iverase commented on pull request #1907: LUCENE-9538: Detect polygon self-intersections in the Tessellator
Posted by GitBox <gi...@apache.org>.
iverase commented on pull request #1907:
URL: https://github.com/apache/lucene-solr/pull/1907#issuecomment-703526645
Performance test shows a small impact in indexing performance:
```
Index time (sec)||Force merge time (sec)||Index size (GB)||Reader heap (MB)||
||Dev||Base||Diff ||Dev ||Base ||diff ||Dev||Base||Diff||Dev||Base||Diff ||
|480.5s|467.0s| 3%|0.0s|0.0s| 0%|2.24|2.24| 0%|0.01|0.01| 0%|
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] iverase commented on pull request #1907: LUCENE-9538: Detect polygon self-intersections in the Tessellator
Posted by GitBox <gi...@apache.org>.
iverase commented on pull request #1907:
URL: https://github.com/apache/lucene-solr/pull/1907#issuecomment-700679293
Hi @nknize, I would like to add this for the upcoming release, do you think you will have time to review it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org