You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@weex.apache.org by x461909066 <gi...@git.apache.org> on 2018/05/04 03:55:08 UTC
[GitHub] incubator-weex pull request #1146: [iOS]bugfix: toast should display on weex...
GitHub user x461909066 opened a pull request:
https://github.com/apache/incubator-weex/pull/1146
[iOS]bugfix: toast should display on weex window
bugfix: weex toast should display on the window that contain weex root view
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/x461909066/incubator-weex bugFix/toast_window
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-weex/pull/1146.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1146
----
commit 1e88b7d54d7462f2da29d683c89e6e04dbe75d21
Author: jinxiaotong <ji...@...>
Date: 2018-05-04T03:32:50Z
[iOS]bugfix: toast should display on weex window
----
---
[GitHub] incubator-weex issue #1146: [iOS]bugfix: toast should display on weex window
Posted by acton393 <gi...@git.apache.org>.
Github user acton393 commented on the issue:
https://github.com/apache/incubator-weex/pull/1146
hi @x461909066 please follow the development-process here, pay more attention to the commit message format http://weex.apache.org/development-process.html
---
[GitHub] incubator-weex issue #1146: [iOS]bugfix: toast should display on weex window
Posted by weex-bot <gi...@git.apache.org>.
Github user weex-bot commented on the issue:
https://github.com/apache/incubator-weex/pull/1146
<!--
0 failure:
0 warning:
2 messages
-->
<table>
<thead>
<tr>
<th width="50"></th>
<th width="100%" data-danger-table="true">Messages</th>
</tr>
</thead>
<tbody><tr>
<td>:book:</td>
<td>has no jsfm file changed.</td>
</tr>
<tr>
<td>:book:</td>
<td>jsfm test finished.</td>
</tr>
</tbody>
</table>
<p align="right">
Generated by :no_entry_sign: <a href="http://github.com/danger/danger-js/">dangerJS</a>
</p>
---
[GitHub] incubator-weex pull request #1146: [iOS]bugfix: toast should display on weex...
Posted by x461909066 <gi...@git.apache.org>.
Github user x461909066 closed the pull request at:
https://github.com/apache/incubator-weex/pull/1146
---
[GitHub] incubator-weex issue #1146: [iOS]bugfix: toast should display on weex window
Posted by x461909066 <gi...@git.apache.org>.
Github user x461909066 commented on the issue:
https://github.com/apache/incubator-weex/pull/1146
bugfix: weex toast should display on the window that contain weex root view
---