[jira] [Commented] (GEODE-8312) Improve redis pub/sub capabilities

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GEODE-8312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17146713#comment-17146713 ] 

ASF GitHub Bot commented on GEODE-8312:
---------------------------------------

dschneider-pivotal commented on a change in pull request #5316:
URL: https://github.com/apache/geode/pull/5316#discussion_r446465548



##########
File path: geode-redis/src/main/java/org/apache/geode/redis/internal/netty/ExecutionHandlerContext.java
##########
@@ -188,6 +188,13 @@ private void executeCommand(ChannelHandlerContext ctx, Command command) throws E
       return;
     }
 
+    if (command.isOfType(RedisCommandType.SELECT)

Review comment:
       I don't understand why this code was added. These commands are on our unimplemented list. Was this added to this PR by accident?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Improve redis pub/sub capabilities
> ----------------------------------
>
>                 Key: GEODE-8312
>                 URL: https://issues.apache.org/jira/browse/GEODE-8312
>             Project: Geode
>          Issue Type: Improvement
>          Components: redis
>            Reporter: Jens Deppe
>            Assignee: Jens Deppe
>            Priority: Major
>
> * Add ability to [P]UNSUBSCRIBE from multiple channels.
> * Match Redis semantics when subscribing to empty channel name.
> * Interact with plain channel names as byte[]s instead of Strings (fixes issues on Windows).



--
This message was sent by Atlassian Jira
(v8.3.4#803005)