[jira] [Commented] (IMPALA-11694) Use C++ atomics for the implementation of gutil/atomicops.h

["Sebastian Pop (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/IMPALA-11694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17719890#comment-17719890 ] 

Sebastian Pop commented on IMPALA-11694:
----------------------------------------

We have seen a similar performance improvements when switching other projects (mysql, posgresql) using the old ARMv8-a load/store exclusive instructions to ARMv8.1-a LSE atomic instructions.
The changes in https://gerrit.cloudera.org/#/c/19185 are replacing the inline assembly (that the compiler is not able to change) with c++11 atomic constructs for which the compiler is able to tune following the hardware capabilities (LSE atomics for example.)


> Use C++ atomics for the implementation of gutil/atomicops.h
> -----------------------------------------------------------
>
>                 Key: IMPALA-11694
>                 URL: https://issues.apache.org/jira/browse/IMPALA-11694
>             Project: IMPALA
>          Issue Type: Improvement
>          Components: Backend
>    Affects Versions: Impala 4.2.0
>            Reporter: Joe McDonnell
>            Priority: Major
>
> Chromium switched the implementation of atomicops.h and family to use the C++11 atomics library in this change:
> [https://github.com/chromium/chromium/commit/57a4e4a50c673c25e9cdaab53e32f6e53aa0b574]
> It allowed for a large simplification later on where most of the platform-specific logic and assembly could be removed. This seems easier to maintain than the current code.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org