You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/10/10 06:01:04 UTC

[GitHub] [pulsar] eolivelli commented on a change in pull request #8219: [pulsar-broker] Fix incorrect broker add-entry latency

eolivelli commented on a change in pull request #8219:
URL: https://github.com/apache/pulsar/pull/8219#discussion_r502751582



##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/stats/NamespaceStats.java
##########
@@ -61,7 +62,8 @@
         }
     }
 
-    public NamespaceStats() {
+    public NamespaceStats(int ratePeriodInSeconds) {
+        this.ratePeriodInSeconds  = ratePeriodInSeconds;

Review comment:
       What about adding a precondition in order to prevent bad errors like division by zero later?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org