You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "kevinjqliu (via GitHub)" <gi...@apache.org> on 2025/12/23 04:23:36 UTC
[PR] infra: release script, validate proper ICEBERG_VERSION variable [iceberg-rust]
kevinjqliu opened a new pull request, #1956:
URL: https://github.com/apache/iceberg-rust/pull/1956
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
- Closes #.
## What changes are included in this PR?
Add a check that the input `ICEBERG_VERSION` variable is in the proper format, i.e. `0.8.0`. Otherwise, the source directory and zip file will have the wrong name
<!--
Provide a summary of the modifications in this PR. List the main changes such as new features, bug fixes, refactoring, or any other updates.
-->
## Are these changes tested?
<!--
Specify what test covers (unit test, integration test, etc.).
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
Added these 3 lines:
```
echo "Release version: $release_version"
echo "Git branch: $git_branch"
echo "Source directory: apache-iceberg-rust-$release_version"
```
This PR:
```
➜ iceberg-rust git:(kevinjqliu/validate-version) ✗ ICEBERG_VERSION=rc.1 ./scripts/release.sh
var is set to 'rc.1'
Error: ICEBERG_VERSION (rc.1) must be in the format: <number>.<number>.<number>
➜ iceberg-rust git:(kevinjqliu/validate-version) ✗ ICEBERG_VERSION=0.8.0 ./scripts/release.sh
var is set to '0.8.0'
Release version: 0.8.0
Git branch: release-0.8.0-rc.1
Source directory: apache-iceberg-rust-0.8.0
```
main:
```
➜ iceberg-rust git:(kevinjqliu/validate-version) ✗ ICEBERG_VERSION=rc.1 ./scripts/release.sh
var is set to 'rc.1'
Release version: rc.1
Git branch: release-rc.1-rc.1
Source directory: apache-iceberg-rust-rc.1
➜ iceberg-rust git:(kevinjqliu/validate-version) ✗ ICEBERG_VERSION=0.8.0 ./scripts/release.sh
var is set to '0.8.0'
Release version: 0.8.0
Git branch: release-0.8.0-rc.1
Source directory: apache-iceberg-rust-0.8.0
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] infra: release script, validate proper ICEBERG_VERSION variable [iceberg-rust]
Posted by "liurenjie1024 (via GitHub)" <gi...@apache.org>.
liurenjie1024 merged PR #1956:
URL: https://github.com/apache/iceberg-rust/pull/1956
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org