You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "ItalyPaleAle (via GitHub)" <gi...@apache.org> on 2023/02/16 01:59:28 UTC

[GitHub] [pulsar-client-go] ItalyPaleAle opened a new pull request, #956: Update github.com/golang-jwt/jwt to v4

ItalyPaleAle opened a new pull request, #956:
URL: https://github.com/apache/pulsar-client-go/pull/956

   ### Motivation
   
   This project depended on the v3 of `github.com/golang-jwt/jwt`. All new versions of the library are now released with the go.mod-enabled `github.com/golang-jwt/jwt/v4` import path (although there are no breaking changes from v3).
   
   This is a security-related library and being on the latest version ensures that any security fix can be applied quickly.
   
   ### Modifications
   
   Updated the golang-jwt library to v4.
   
   ### Verifying this change
   
   - [X] Make sure that the change passes the CI checks.
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   ### Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): **yes**
     - The public API: no
     - The schema: no
     - The default values of configurations: no
     - The wire protocol: no
   
   ### Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? not applicable
     - If a feature is not applicable for documentation, explain why? Internal change only
     - If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Update github.com/golang-jwt/jwt to v4 [pulsar-client-go]

Posted by "nodece (via GitHub)" <gi...@apache.org>.
nodece closed pull request #956: Update github.com/golang-jwt/jwt to v4
URL: https://github.com/apache/pulsar-client-go/pull/956


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Update github.com/golang-jwt/jwt to v4 [pulsar-client-go]

Posted by "nodece (via GitHub)" <gi...@apache.org>.
nodece commented on PR #956:
URL: https://github.com/apache/pulsar-client-go/pull/956#issuecomment-2105925259

   Closed by https://github.com/apache/pulsar-client-go/pull/1214


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar-client-go] nodece commented on pull request #956: Update github.com/golang-jwt/jwt to v4

Posted by "nodece (via GitHub)" <gi...@apache.org>.
nodece commented on PR #956:
URL: https://github.com/apache/pulsar-client-go/pull/956#issuecomment-1441395678

   @ItalyPaleAle Any updates?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar-client-go] ItalyPaleAle commented on pull request #956: Update github.com/golang-jwt/jwt to v4

Posted by "ItalyPaleAle (via GitHub)" <gi...@apache.org>.
ItalyPaleAle commented on PR #956:
URL: https://github.com/apache/pulsar-client-go/pull/956#issuecomment-1442275887

   @nodece  my apologies, I disabled notifications for when CI fails (because I was getting spammed) so I didn't get alerted.
   
   The CI is failing because it's trying to run tests using Go 1.16, but the `go.mod` file says that the minimum version is 1.18. I don't think it's an issue I can fix here :(


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org