You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "jacktengg (via GitHub)" <gi...@apache.org> on 2024/02/01 08:02:33 UTC
[PR] [fix](decimal) fix arithmetic overflow error of casting decimal null values [doris]
jacktengg opened a new pull request, #30700:
URL: https://github.com/apache/doris/pull/30700
## Proposed changes
Fix of #30272
<!--Describe your changes.-->
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](decimal) fix arithmetic overflow error of casting decimal null values [doris]
Posted by "zhaohehuhu (via GitHub)" <gi...@apache.org>.
zhaohehuhu commented on PR #30700:
URL: https://github.com/apache/doris/pull/30700#issuecomment-1974228407
same issue in 2.0.4.rc06
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](decimal) fix arithmetic overflow error of casting decimal null values [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #30700:
URL: https://github.com/apache/doris/pull/30700#issuecomment-1920732008
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](decimal) fix arithmetic overflow error of casting decimal null values [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #30700:
URL: https://github.com/apache/doris/pull/30700#issuecomment-1920834048
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](decimal) fix arithmetic overflow error of casting decimal null values [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30700:
URL: https://github.com/apache/doris/pull/30700#issuecomment-1920775660
<details>
<summary>TPC-DS: <b>Total hot run time: 237976 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 6b33afe04a3ddef56c09f17c6ff90a1aedee652e, data reload: false
query1 935 389 383 383
query2 6522 2299 2064 2064
query3 6916 212 203 203
query4 20079 18260 18207 18207
query5 19715 6246 6225 6225
query6 294 218 219 218
query7 4151 291 304 291
query8 260 270 234 234
query9 3053 2628 2567 2567
query10 407 292 281 281
query11 11418 10901 10747 10747
query12 120 76 74 74
query13 5667 627 635 627
query14 17305 13337 13377 13337
query15 354 233 237 233
query16 6446 260 259 259
query17 3209 885 869 869
query18 2260 399 403 399
query19 217 141 153 141
query20 79 73 74 73
query21 190 98 93 93
query22 5358 4955 4830 4830
query23 32466 31903 31931 31903
query24 6950 6481 6471 6471
query25 496 418 398 398
query26 527 162 166 162
query27 1898 286 299 286
query28 6129 2243 2211 2211
query29 2860 2804 2758 2758
query30 238 162 160 160
query31 909 713 764 713
query32 67 60 59 59
query33 387 237 236 236
query34 841 465 473 465
query35 1127 969 955 955
query36 1601 1468 1699 1468
query37 88 64 60 60
query38 3094 2954 2973 2954
query39 1353 1311 1323 1311
query40 195 95 95 95
query41 34 32 32 32
query42 86 85 78 78
query43 635 626 681 626
query44 1119 701 717 701
query45 242 228 226 226
query46 1249 981 982 981
query47 2039 1649 1778 1649
query48 967 687 675 675
query49 612 362 368 362
query50 854 590 565 565
query51 5646 5447 5506 5447
query52 108 78 88 78
query53 433 318 305 305
query54 2415 2226 2274 2226
query55 87 79 82 79
query56 207 201 191 191
query57 1207 1123 1048 1048
query58 207 190 203 190
query59 3472 3605 3316 3316
query60 203 199 182 182
query61 86 81 83 81
query62 791 482 448 448
query63 477 332 323 323
query64 1993 1346 1395 1346
query65 3711 3589 3620 3589
query66 825 362 353 353
query67 15909 15706 14854 14854
query68 8388 652 682 652
query69 564 322 339 322
query70 2064 1921 1904 1904
query71 383 295 318 295
query72 4542 3342 3337 3337
query73 722 327 319 319
query74 6310 5919 5885 5885
query75 4342 3476 3559 3476
query76 4888 1187 1144 1144
query77 789 249 260 249
query78 31777 53419 47700 47700
query79 15349 659 635 635
query80 4886 385 382 382
query81 557 242 229 229
query82 832 105 98 98
query83 406 135 130 130
query84 253 70 71 70
query85 2549 286 283 283
query86 476 399 372 372
query87 3213 3051 3027 3027
query88 6402 2348 2322 2322
query89 415 295 274 274
query90 2485 207 205 205
query91 153 116 118 116
query92 67 50 50 50
query93 5113 599 565 565
query94 1838 208 212 208
query95 1098 1072 1064 1064
query96 650 338 321 321
query97 6625 6357 6381 6357
query98 188 181 158 158
query99 3923 856 1028 856
Total cold run time: 344042 ms
Total hot run time: 237976 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](decimal) fix arithmetic overflow error of casting decimal null values [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30700:
URL: https://github.com/apache/doris/pull/30700#issuecomment-1920791456
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
```
Load test result on commit 6b33afe04a3ddef56c09f17c6ff90a1aedee652e with default session variables
Stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
Stream load orc: 58 seconds loaded 1101869774 Bytes, about 18 MB/s
Stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
Insert into select: 21.4 seconds inserted 10000000 Rows, about 467K ops/s
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](decimal) fix arithmetic overflow error of casting decimal null values [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30700:
URL: https://github.com/apache/doris/pull/30700#issuecomment-1920753400
<details>
<summary>TPC-H: <b>Total hot run time: 50560 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 6b33afe04a3ddef56c09f17c6ff90a1aedee652e, data reload: false
------ Round 1 ----------------------------------
q1 17547 4422 4335 4335
q2 2026 151 144 144
q3 10277 1937 1949 1937
q4 10099 1241 1316 1241
q5 8482 4015 4018 4015
q6 221 125 123 123
q7 2036 1578 1584 1578
q8 9309 2727 2720 2720
q9 11103 11473 10995 10995
q10 8638 3556 3530 3530
q11 422 241 233 233
q12 462 300 304 300
q13 18333 3969 4083 3969
q14 348 318 331 318
q15 502 463 454 454
q16 686 590 600 590
q17 1133 968 957 957
q18 7309 6907 6885 6885
q19 1675 1567 1479 1479
q20 520 296 299 296
q21 4411 4061 4111 4061
q22 513 400 402 400
Total cold run time: 116052 ms
Total hot run time: 50560 ms
----- Round 2, with runtime_filter_mode=off -----
q1 4334 4291 4255 4255
q2 321 230 225 225
q3 4155 4183 4148 4148
q4 2735 2748 2742 2742
q5 7334 7314 7220 7220
q6 234 120 118 118
q7 3251 2872 2851 2851
q8 4369 4471 4529 4471
q9 17619 17342 17287 17287
q10 4286 4276 4270 4270
q11 771 729 687 687
q12 1022 840 859 840
q13 6694 3735 3710 3710
q14 461 418 414 414
q15 500 467 458 458
q16 760 710 719 710
q17 3896 3837 3863 3837
q18 8968 8702 8762 8702
q19 1734 1717 1655 1655
q20 2418 2143 2129 2129
q21 8690 8548 8645 8548
q22 1020 975 955 955
Total cold run time: 85572 ms
Total hot run time: 80232 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](decimal) fix arithmetic overflow error of casting decimal null values [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #30700:
URL: https://github.com/apache/doris/pull/30700#issuecomment-1920833962
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](decimal) fix arithmetic overflow error of casting decimal null values [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30700:
URL: https://github.com/apache/doris/pull/30700#issuecomment-1920720898
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](decimal) fix arithmetic overflow error of casting decimal null values [doris]
Posted by "jacktengg (via GitHub)" <gi...@apache.org>.
jacktengg commented on PR #30700:
URL: https://github.com/apache/doris/pull/30700#issuecomment-1920722148
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](decimal) fix arithmetic overflow error of casting decimal null values [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30700:
URL: https://github.com/apache/doris/pull/30700#issuecomment-1920784660
<details>
<summary>ClickBench: <b>Total hot run time: 30.75 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 6b33afe04a3ddef56c09f17c6ff90a1aedee652e, data reload: false
query1 0.02 0.02 0.02
query2 0.06 0.02 0.02
query3 0.25 0.06 0.06
query4 1.81 0.10 0.07
query5 0.53 0.53 0.52
query6 1.23 0.60 0.63
query7 0.01 0.01 0.01
query8 0.04 0.02 0.02
query9 0.50 0.49 0.48
query10 0.53 0.53 0.53
query11 0.11 0.08 0.09
query12 0.12 0.09 0.09
query13 0.62 0.62 0.60
query14 0.80 0.78 0.77
query15 0.78 0.77 0.75
query16 0.38 0.37 0.37
query17 1.02 0.97 1.04
query18 0.23 0.23 0.27
query19 1.93 1.87 1.86
query20 0.01 0.01 0.01
query21 15.48 0.57 0.55
query22 2.15 1.84 1.55
query23 17.40 1.09 1.00
query24 8.10 1.22 0.91
query25 1.54 0.12 0.11
query26 0.39 0.14 0.14
query27 0.11 0.11 0.11
query28 6.00 0.73 0.71
query29 12.76 2.35 2.23
query30 0.56 0.52 0.53
query31 2.82 0.38 0.38
query32 3.40 0.49 0.50
query33 3.07 3.07 3.03
query34 15.29 4.82 4.82
query35 4.86 4.89 4.89
query36 1.10 1.01 1.03
query37 0.05 0.04 0.04
query38 0.04 0.03 0.02
query39 0.02 0.01 0.01
query40 0.16 0.14 0.14
query41 0.06 0.02 0.01
query42 0.02 0.02 0.01
query43 0.02 0.01 0.02
Total cold run time: 106.38 s
Total hot run time: 30.75 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](decimal) fix arithmetic overflow error of casting decimal null values [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30700:
URL: https://github.com/apache/doris/pull/30700#issuecomment-1920769143
TeamCity be ut coverage result:
Function Coverage: 37.84% (8034/21232)
Line Coverage: 29.54% (65466/221609)
Region Coverage: 28.96% (33622/116104)
Branch Coverage: 24.82% (17254/69506)
Coverage Report: http://coverage.selectdb-in.cc/coverage/6b33afe04a3ddef56c09f17c6ff90a1aedee652e_6b33afe04a3ddef56c09f17c6ff90a1aedee652e/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](decimal) fix arithmetic overflow error of casting decimal null values [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #30700:
URL: https://github.com/apache/doris/pull/30700#issuecomment-1920731787
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](decimal) fix arithmetic overflow error of casting decimal null values [doris]
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei merged PR #30700:
URL: https://github.com/apache/doris/pull/30700
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org