You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/07/22 16:02:02 UTC
[GitHub] [incubator-nuttx] anchao opened a new pull request #4210: net/tcp: add Selective-ACK support
anchao opened a new pull request #4210:
URL: https://github.com/apache/incubator-nuttx/pull/4210
## Summary
net/tcp: add Selective-ACK support
net/tcp: d_appdata should remove the tcp specific option field
net/tcp: add out-of-order segment support
mm/iob: add qentry private data support
Reference:
https://datatracker.ietf.org/doc/html/rfc2018
## Impact
TCP accurate fast retransmission and recovery
## Testing
HTTP audio streaming
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] yamt commented on a change in pull request #4210: net/tcp: add Selective-ACK support
Posted by GitBox <gi...@apache.org>.
yamt commented on a change in pull request #4210:
URL: https://github.com/apache/incubator-nuttx/pull/4210#discussion_r679635935
##########
File path: net/tcp/tcp_input.c
##########
@@ -565,9 +836,24 @@ static void tcp_input(FAR struct net_driver_s *dev, uint8_t domain,
}
else
{
- /* We never queue out-of-order segments. */
+#ifdef CONFIG_NET_TCP_OUT_OF_ORDER_QUEUE
+ dev->d_len += hdrlen;
+ tcp_input_ofo(dev, conn, iplen);
+
+# ifdef CONFIG_NET_TCP_SELECTIVE_ACK
+ if (conn->flags | TCP_SACK)
Review comment:
i guess you meant something different here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] anchao commented on pull request #4210: net/tcp: add Selective-ACK support
Posted by GitBox <gi...@apache.org>.
anchao commented on pull request #4210:
URL: https://github.com/apache/incubator-nuttx/pull/4210#issuecomment-885376197
> We should split this PR into 2. The IOB change should be separate from the TCP changes.
OK, I split the iob part to https://github.com/apache/incubator-nuttx/pull/4211
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org