You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Greg Mann <gr...@mesosphere.io> on 2017/03/03 18:50:53 UTC
Review Request 57298: Added a new libprocess test for invalid
principals.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57298/
-----------------------------------------------------------
Review request for mesos, Alexander Rojas, Jan Schlicht, and Vinod Kone.
Bugs: MESOS-7003
https://issues.apache.org/jira/browse/MESOS-7003
Repository: mesos
Description
-------
This patch adds `HttpAuthenticationTest.InvalidPrincipal` to
libprocess to verify that requests return a 500 status code
when the authenticator fails to return a valid principal.
Diffs
-----
3rdparty/libprocess/src/tests/http_tests.cpp fb4da9aecff0370d97a15269c5d8fffb30e0478f
Diff: https://reviews.apache.org/r/57298/diff/1/
Testing
-------
Testing details can be found at the end of this patch chain.
Thanks,
Greg Mann
Re: Review Request 57298: Added a new libprocess test for invalid
principals.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57298/
-----------------------------------------------------------
(Updated March 4, 2017, 1:36 a.m.)
Review request for mesos, Alexander Rojas, Jan Schlicht, and Vinod Kone.
Changes
-------
Stopped using the `Principal()` default constructor.
Bugs: MESOS-7003
https://issues.apache.org/jira/browse/MESOS-7003
Repository: mesos
Description
-------
This patch adds `HttpAuthenticationTest.InvalidPrincipal` to
libprocess to verify that requests return a 500 status code
when the authenticator fails to return a valid principal.
Diffs (updated)
-----
3rdparty/libprocess/src/tests/http_tests.cpp fb4da9aecff0370d97a15269c5d8fffb30e0478f
Diff: https://reviews.apache.org/r/57298/diff/2/
Changes: https://reviews.apache.org/r/57298/diff/1-2/
Testing
-------
Testing details can be found at the end of this patch chain.
Thanks,
Greg Mann
Re: Review Request 57298: Added a new libprocess test for invalid
principals.
Posted by Greg Mann <gr...@mesosphere.io>.
> On March 4, 2017, 12:35 a.m., Vinod Kone wrote:
> > 3rdparty/libprocess/src/tests/http_tests.cpp
> > Lines 1873 (patched)
> > <https://reviews.apache.org/r/57298/diff/1/?file=1655632#file1655632line1873>
> >
> > should we `delete` this constructor as a way to enforce? ofcourse one could still call `Principal(None(), None())` to mimic this. just a thought.
Excellent idea, thx!! Just updated the patches accordingly.
- Greg
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57298/#review167910
-----------------------------------------------------------
On March 4, 2017, 1:36 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57298/
> -----------------------------------------------------------
>
> (Updated March 4, 2017, 1:36 a.m.)
>
>
> Review request for mesos, Alexander Rojas, Jan Schlicht, and Vinod Kone.
>
>
> Bugs: MESOS-7003
> https://issues.apache.org/jira/browse/MESOS-7003
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds `HttpAuthenticationTest.InvalidPrincipal` to
> libprocess to verify that requests return a 500 status code
> when the authenticator fails to return a valid principal.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/tests/http_tests.cpp fb4da9aecff0370d97a15269c5d8fffb30e0478f
>
>
> Diff: https://reviews.apache.org/r/57298/diff/2/
>
>
> Testing
> -------
>
> Testing details can be found at the end of this patch chain.
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 57298: Added a new libprocess test for invalid
principals.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57298/#review167910
-----------------------------------------------------------
Ship it!
3rdparty/libprocess/src/tests/http_tests.cpp
Lines 1873 (patched)
<https://reviews.apache.org/r/57298/#comment239879>
should we `delete` this constructor as a way to enforce? ofcourse one could still call `Principal(None(), None())` to mimic this. just a thought.
- Vinod Kone
On March 3, 2017, 6:50 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57298/
> -----------------------------------------------------------
>
> (Updated March 3, 2017, 6:50 p.m.)
>
>
> Review request for mesos, Alexander Rojas, Jan Schlicht, and Vinod Kone.
>
>
> Bugs: MESOS-7003
> https://issues.apache.org/jira/browse/MESOS-7003
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds `HttpAuthenticationTest.InvalidPrincipal` to
> libprocess to verify that requests return a 500 status code
> when the authenticator fails to return a valid principal.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/tests/http_tests.cpp fb4da9aecff0370d97a15269c5d8fffb30e0478f
>
>
> Diff: https://reviews.apache.org/r/57298/diff/1/
>
>
> Testing
> -------
>
> Testing details can be found at the end of this patch chain.
>
>
> Thanks,
>
> Greg Mann
>
>