You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/03/06 00:46:06 UTC
[GitHub] [airflow] kaxil opened a new pull request #14638: Cache Hook when initializing `CloudFormationCreateStackSensor`
kaxil opened a new pull request #14638:
URL: https://github.com/apache/airflow/pull/14638
- `CloudFormationCreateStackSensor` created `AWSCloudFormationHook` in its init method
- This commit delays creation of hook until it is needed
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on a change in pull request #14638: Cache Hook when initializing `CloudFormationCreateStackSensor`
Posted by GitBox <gi...@apache.org>.
eladkal commented on a change in pull request #14638:
URL: https://github.com/apache/airflow/pull/14638#discussion_r588921407
##########
File path: airflow/providers/amazon/aws/sensors/cloud_formation.py
##########
@@ -18,6 +18,11 @@
"""This module contains sensors for AWS CloudFormation."""
from typing import Optional
+try:
+ from functools import cached_property
+except ImportError:
+ from cached_property import cached_property
Review comment:
We do, see https://github.com/apache/airflow/pull/14606
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil merged pull request #14638: Cache Hook when initializing `CloudFormationCreateStackSensor`
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #14638:
URL: https://github.com/apache/airflow/pull/14638
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek commented on a change in pull request #14638: Cache Hook when initializing `CloudFormationCreateStackSensor`
Posted by GitBox <gi...@apache.org>.
turbaszek commented on a change in pull request #14638:
URL: https://github.com/apache/airflow/pull/14638#discussion_r588907051
##########
File path: airflow/providers/amazon/aws/sensors/cloud_formation.py
##########
@@ -18,6 +18,11 @@
"""This module contains sensors for AWS CloudFormation."""
from typing import Optional
+try:
+ from functools import cached_property
+except ImportError:
+ from cached_property import cached_property
Review comment:
If this is an issue then we probably should fix all other operators that use `from cached_propert`, WDYT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #14638: Cache Hook when initializing `CloudFormationCreateStackSensor`
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14638:
URL: https://github.com/apache/airflow/pull/14638#issuecomment-791993034
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest master or amend the last commit of the PR, and push it with --force-with-lease.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek commented on a change in pull request #14638: Cache Hook when initializing `CloudFormationCreateStackSensor`
Posted by GitBox <gi...@apache.org>.
turbaszek commented on a change in pull request #14638:
URL: https://github.com/apache/airflow/pull/14638#discussion_r588906960
##########
File path: airflow/providers/amazon/aws/sensors/cloud_formation.py
##########
@@ -18,6 +18,11 @@
"""This module contains sensors for AWS CloudFormation."""
from typing import Optional
+try:
+ from functools import cached_property
+except ImportError:
+ from cached_property import cached_property
Review comment:
Is there a reason why we need both imports?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #14638: Cache Hook when initializing `CloudFormationCreateStackSensor`
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #14638:
URL: https://github.com/apache/airflow/pull/14638#discussion_r589074917
##########
File path: airflow/providers/amazon/aws/sensors/cloud_formation.py
##########
@@ -18,6 +18,11 @@
"""This module contains sensors for AWS CloudFormation."""
from typing import Optional
+try:
+ from functools import cached_property
+except ImportError:
+ from cached_property import cached_property
Review comment:
Yup, like Elad mentioned #14606 removed the dep for Python 3.8 users. this just build on top of that
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org