You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cxf.apache.org by GitBox <gi...@apache.org> on 2020/04/03 05:53:25 UTC
[GitHub] [cxf] deki opened a new pull request #657: [CXF-8151] Upgrade to
Bean Validation 2.x and Hibernate Validator 6.1.0
deki opened a new pull request #657: [CXF-8151] Upgrade to Bean Validation 2.x and Hibernate Validator 6.1.0
URL: https://github.com/apache/cxf/pull/657
along with Swagger Core 2.1.2
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cxf] ilgrosso commented on issue #657: [CXF-8151] Upgrade to Bean
Validation 2.x and Hibernate Validator 6.1.0
Posted by GitBox <gi...@apache.org>.
ilgrosso commented on issue #657: [CXF-8151] Upgrade to Bean Validation 2.x and Hibernate Validator 6.1.0
URL: https://github.com/apache/cxf/pull/657#issuecomment-608250583
It should be only in [a class](https://github.com/apache/cxf/blob/master/osgi/itests/src/test/java/org/apache/cxf/osgi/itests/jaxrs/BookStore.java) even though AFAICT there should never be need to explicitly call a given impl.
Anyway, I understand such a change might not be completely on-scope here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cxf] ilgrosso commented on issue #657: [CXF-8151] Upgrade to Bean
Validation 2.x and Hibernate Validator 6.1.0
Posted by GitBox <gi...@apache.org>.
ilgrosso commented on issue #657: [CXF-8151] Upgrade to Bean Validation 2.x and Hibernate Validator 6.1.0
URL: https://github.com/apache/cxf/pull/657#issuecomment-608247466
@deki exactly: I was thinking why we don't switch to BVal rather than upgrading Hibernate Validator, as in its latest version BVal is implementing Bean Validation 2.x anyway.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cxf] deki merged pull request #657: [CXF-8151] Upgrade to Bean
Validation 2.x and Hibernate Validator 6.1.0
Posted by GitBox <gi...@apache.org>.
deki merged pull request #657: [CXF-8151] Upgrade to Bean Validation 2.x and Hibernate Validator 6.1.0
URL: https://github.com/apache/cxf/pull/657
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cxf] deki commented on issue #657: [CXF-8151] Upgrade to Bean
Validation 2.x and Hibernate Validator 6.1.0
Posted by GitBox <gi...@apache.org>.
deki commented on issue #657: [CXF-8151] Upgrade to Bean Validation 2.x and Hibernate Validator 6.1.0
URL: https://github.com/apache/cxf/pull/657#issuecomment-608250962
I'd suggest we try to finish this one and try the BVal changes afterwards.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cxf] reta commented on a change in pull request #657: [CXF-8151]
Upgrade to Bean Validation 2.x and Hibernate Validator 6.1.0
Posted by GitBox <gi...@apache.org>.
reta commented on a change in pull request #657: [CXF-8151] Upgrade to Bean Validation 2.x and Hibernate Validator 6.1.0
URL: https://github.com/apache/cxf/pull/657#discussion_r405214903
##########
File path: osgi/karaf/features/src/main/resources/features.xml
##########
@@ -314,7 +314,7 @@
<bundle start-level="35">mvn:org.apache.cxf/cxf-rt-rs-service-description-swagger-ui/${project.version}</bundle>
<bundle start-level="40">mvn:org.apache.cxf/cxf-rt-rs-service-description-swagger/${project.version}</bundle>
<bundle start-level="35" dependency="true">mvn:com.fasterxml.jackson.datatype/jackson-datatype-jsr310/${cxf.jackson.version}</bundle>
- <bundle start-level="10" dependency="true">mvn:jakarta.validation/jakarta.validation-api/${cxf.validation.api.version}</bundle>
+ <bundle start-level="10" dependency="true">mvn:javax.validation/validation-api/1.1.0.Final</bundle>
Review comment:
@amarkevich It would be better to override manifest instead,
```
<bundle start-level="10" dependency="true">mvn:jakarta.validation/jakarta.validation-api/${cxf.validation.api.version}$overwrite=merge&javax.validation.constraints;version="[1.1,3)"</bundle>
```
I have sent the PR against 1.6.x branch as well (https://github.com/swagger-api/swagger-core/pull/3497) but it may take some time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cxf] amarkevich commented on a change in pull request #657:
[CXF-8151] Upgrade to Bean Validation 2.x and Hibernate Validator 6.1.0
Posted by GitBox <gi...@apache.org>.
amarkevich commented on a change in pull request #657: [CXF-8151] Upgrade to Bean Validation 2.x and Hibernate Validator 6.1.0
URL: https://github.com/apache/cxf/pull/657#discussion_r405460273
##########
File path: osgi/karaf/features/src/main/resources/features.xml
##########
@@ -314,7 +314,7 @@
<bundle start-level="35">mvn:org.apache.cxf/cxf-rt-rs-service-description-swagger-ui/${project.version}</bundle>
<bundle start-level="40">mvn:org.apache.cxf/cxf-rt-rs-service-description-swagger/${project.version}</bundle>
<bundle start-level="35" dependency="true">mvn:com.fasterxml.jackson.datatype/jackson-datatype-jsr310/${cxf.jackson.version}</bundle>
- <bundle start-level="10" dependency="true">mvn:jakarta.validation/jakarta.validation-api/${cxf.validation.api.version}</bundle>
+ <bundle start-level="10" dependency="true">mvn:javax.validation/validation-api/1.1.0.Final</bundle>
Review comment:
added
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cxf] reta commented on a change in pull request #657: [CXF-8151]
Upgrade to Bean Validation 2.x and Hibernate Validator 6.1.0
Posted by GitBox <gi...@apache.org>.
reta commented on a change in pull request #657: [CXF-8151] Upgrade to Bean Validation 2.x and Hibernate Validator 6.1.0
URL: https://github.com/apache/cxf/pull/657#discussion_r405214903
##########
File path: osgi/karaf/features/src/main/resources/features.xml
##########
@@ -314,7 +314,7 @@
<bundle start-level="35">mvn:org.apache.cxf/cxf-rt-rs-service-description-swagger-ui/${project.version}</bundle>
<bundle start-level="40">mvn:org.apache.cxf/cxf-rt-rs-service-description-swagger/${project.version}</bundle>
<bundle start-level="35" dependency="true">mvn:com.fasterxml.jackson.datatype/jackson-datatype-jsr310/${cxf.jackson.version}</bundle>
- <bundle start-level="10" dependency="true">mvn:jakarta.validation/jakarta.validation-api/${cxf.validation.api.version}</bundle>
+ <bundle start-level="10" dependency="true">mvn:javax.validation/validation-api/1.1.0.Final</bundle>
Review comment:
@amarkevich It would be better to override manifest instead,
```
<bundle start-level="35" dependency="true">mvn:io.swagger/swagger-core/${cxf.swagger2.version}$overwrite=merge&javax.validation.constraints;version="[1.1,3)"</bundle>
```
I have sent the PR against 1.6.x branch as well (https://github.com/swagger-api/swagger-core/pull/3497) but it may take some time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cxf] reta commented on a change in pull request #657: [CXF-8151]
Upgrade to Bean Validation 2.x and Hibernate Validator 6.1.0
Posted by GitBox <gi...@apache.org>.
reta commented on a change in pull request #657: [CXF-8151] Upgrade to Bean Validation 2.x and Hibernate Validator 6.1.0
URL: https://github.com/apache/cxf/pull/657#discussion_r405903397
##########
File path: osgi/karaf/features/src/main/resources/features.xml
##########
@@ -314,7 +314,7 @@
<bundle start-level="35">mvn:org.apache.cxf/cxf-rt-rs-service-description-swagger-ui/${project.version}</bundle>
<bundle start-level="40">mvn:org.apache.cxf/cxf-rt-rs-service-description-swagger/${project.version}</bundle>
<bundle start-level="35" dependency="true">mvn:com.fasterxml.jackson.datatype/jackson-datatype-jsr310/${cxf.jackson.version}</bundle>
- <bundle start-level="10" dependency="true">mvn:jakarta.validation/jakarta.validation-api/${cxf.validation.api.version}</bundle>
+ <bundle start-level="10" dependency="true">mvn:javax.validation/validation-api/1.1.0.Final</bundle>
Review comment:
:+1: Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cxf] reta commented on issue #657: [CXF-8151] Upgrade to Bean
Validation 2.x and Hibernate Validator 6.1.0
Posted by GitBox <gi...@apache.org>.
reta commented on issue #657: [CXF-8151] Upgrade to Bean Validation 2.x and Hibernate Validator 6.1.0
URL: https://github.com/apache/cxf/pull/657#issuecomment-611275225
@deki @amarkevich I think we could merge it like that guys, and keep Swagger Core 1.6.x on the radar, thoughts?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cxf] ilgrosso commented on issue #657: [CXF-8151] Upgrade to Bean
Validation 2.x and Hibernate Validator 6.1.0
Posted by GitBox <gi...@apache.org>.
ilgrosso commented on issue #657: [CXF-8151] Upgrade to Bean Validation 2.x and Hibernate Validator 6.1.0
URL: https://github.com/apache/cxf/pull/657#issuecomment-608244405
@deki Why not moving Apache BVal instead (latest version: 2.0.3)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cxf] deki commented on issue #657: [CXF-8151] Upgrade to Bean
Validation 2.x and Hibernate Validator 6.1.0
Posted by GitBox <gi...@apache.org>.
deki commented on issue #657: [CXF-8151] Upgrade to Bean Validation 2.x and Hibernate Validator 6.1.0
URL: https://github.com/apache/cxf/pull/657#issuecomment-608247065
@ilgrosso CXF is not using BVal, is it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cxf] deki commented on issue #657: [CXF-8151] Upgrade to Bean
Validation 2.x and Hibernate Validator 6.1.0
Posted by GitBox <gi...@apache.org>.
deki commented on issue #657: [CXF-8151] Upgrade to Bean Validation 2.x and Hibernate Validator 6.1.0
URL: https://github.com/apache/cxf/pull/657#issuecomment-608249346
Ok got it. Well I like the idea but it's not just drop-in replacement, for example I see references to org.hibernate.validator classes in samples
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services