You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "jeqo (via GitHub)" <gi...@apache.org> on 2023/06/30 10:17:27 UTC
[GitHub] [kafka] jeqo opened a new pull request, #13938: KAFKA-15135: fix(storage): pass endpoint configurations as client commont to TBRLMM
jeqo opened a new pull request, #13938:
URL: https://github.com/apache/kafka/pull/13938
Pass endpoint properties from RLM to TBRLMM and validate those are not ignored.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] showuon merged pull request #13938: KAFKA-15135: fix(storage): pass endpoint configurations as client commont to TBRLMM
Posted by "showuon (via GitHub)" <gi...@apache.org>.
showuon merged PR #13938:
URL: https://github.com/apache/kafka/pull/13938
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] jeqo commented on a diff in pull request #13938: KAFKA-15135: fix(storage): pass endpoint configurations as client commont to TBRLMM
Posted by "jeqo (via GitHub)" <gi...@apache.org>.
jeqo commented on code in PR #13938:
URL: https://github.com/apache/kafka/pull/13938#discussion_r1247786162
##########
core/src/test/java/kafka/log/remote/RemoteLogManagerTest.java:
##########
@@ -220,8 +220,8 @@ void testRemoteLogMetadataManagerWithEndpointConfig() {
ArgumentCaptor<Map<String, Object>> capture = ArgumentCaptor.forClass(Map.class);
verify(remoteLogMetadataManager, times(1)).configure(capture.capture());
- assertEquals(host + ":" + port, capture.getValue().get("bootstrap.servers"));
- assertEquals(securityProtocol, capture.getValue().get("security.protocol"));
+ assertEquals(host + ":" + port, capture.getValue().get("remote.log.metadata.common.client.bootstrap.servers"));
+ assertEquals(securityProtocol, capture.getValue().get("remote.log.metadata.common.client.security.protocol"));
Review Comment:
Sure, I was following the text content instead, but we can use the constant here as well. Applying fix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] showuon commented on a diff in pull request #13938: KAFKA-15135: fix(storage): pass endpoint configurations as client commont to TBRLMM
Posted by "showuon (via GitHub)" <gi...@apache.org>.
showuon commented on code in PR #13938:
URL: https://github.com/apache/kafka/pull/13938#discussion_r1247736125
##########
core/src/test/java/kafka/log/remote/RemoteLogManagerTest.java:
##########
@@ -220,8 +220,8 @@ void testRemoteLogMetadataManagerWithEndpointConfig() {
ArgumentCaptor<Map<String, Object>> capture = ArgumentCaptor.forClass(Map.class);
verify(remoteLogMetadataManager, times(1)).configure(capture.capture());
- assertEquals(host + ":" + port, capture.getValue().get("bootstrap.servers"));
- assertEquals(securityProtocol, capture.getValue().get("security.protocol"));
+ assertEquals(host + ":" + port, capture.getValue().get("remote.log.metadata.common.client.bootstrap.servers"));
+ assertEquals(securityProtocol, capture.getValue().get("remote.log.metadata.common.client.security.protocol"));
Review Comment:
Any reason why don't we use `REMOTE_LOG_METADATA_COMMON_CLIENT_PREFIX` like other places did?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] showuon commented on pull request #13938: KAFKA-15135: fix(storage): pass endpoint configurations as client commont to TBRLMM
Posted by "showuon (via GitHub)" <gi...@apache.org>.
showuon commented on PR #13938:
URL: https://github.com/apache/kafka/pull/13938#issuecomment-1617082170
Failed tests are unrelated:
```
Build / JDK 8 and Scala 2.12 / org.apache.kafka.connect.mirror.integration.MirrorConnectorsIntegrationTransactionsTest.testReplicationWithEmptyPartition()
Build / JDK 8 and Scala 2.12 / org.apache.kafka.connect.integration.TransformationIntegrationTest.testFilterOnTopicNameWithSinkConnector
Build / JDK 8 and Scala 2.12 / integration.kafka.server.FetchFromFollowerIntegrationTest.testRackAwareRangeAssignor()
Build / JDK 8 and Scala 2.12 / kafka.admin.ResetConsumerGroupOffsetTest.testResetOffsetsShiftMinus()
Build / JDK 8 and Scala 2.12 / kafka.admin.ResetConsumerGroupOffsetTest.testResetOffsetsByDurationFallbackToLatestWhenNoRecords()
Build / JDK 8 and Scala 2.12 / kafka.admin.TopicCommandIntegrationTest.testDescribeUnderMinIsrPartitions(String).quorum=kraft
Build / JDK 8 and Scala 2.12 / org.apache.kafka.streams.integration.LagFetchIntegrationTest.shouldFetchLagsDuringRestoration()
Build / JDK 17 and Scala 2.13 / kafka.api.TransactionsTest.testBumpTransactionalEpoch(String).quorum=kraft
Build / JDK 17 and Scala 2.13 / org.apache.kafka.controller.QuorumControllerTest.testBalancePartitionLeaders()
Build / JDK 20 and Scala 2.13 / org.apache.kafka.connect.mirror.integration.IdentityReplicationIntegrationTest.testReplicateSourceDefault()
Build / JDK 20 and Scala 2.13 / org.apache.kafka.connect.mirror.integration.MirrorConnectorsIntegrationExactlyOnceTest.testOffsetTranslationBehindReplicationFlow()
Build / JDK 20 and Scala 2.13 / org.apache.kafka.streams.integration.NamedTopologyIntegrationTest.shouldRemoveOneNamedTopologyWhileAnotherContinuesProcessing()
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-15135: fix(storage): pass endpoint configurations as client commont to TBRLMM [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on code in PR #13938:
URL: https://github.com/apache/kafka/pull/13938#discussion_r2483764785
##########
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##########
@@ -237,8 +239,8 @@ private void configureRLMM() {
rlmmProps.put(KafkaConfig.LogDirProp(), logDir);
rlmmProps.put("cluster.id", clusterId);
endpoint.ifPresent(e -> {
- rlmmProps.put("bootstrap.servers", e.host() + ":" + e.port());
- rlmmProps.put("security.protocol", e.securityProtocol().name);
+ rlmmProps.put(REMOTE_LOG_METADATA_COMMON_CLIENT_PREFIX + "bootstrap.servers", e.host() + ":" + e.port());
+ rlmmProps.put(REMOTE_LOG_METADATA_COMMON_CLIENT_PREFIX + "security.protocol", e.securityProtocol().name);
Review Comment:
What happens if "this" cluster uses security and the "target" uses `PLAINTEXT`? Users might configure `remote.log.metadata.common.client.bootstrap.servers` but omit `remote.log.metadata.common.client.security.protocol`. It results in those client components will mistakenly try to connect to the `PLAINTEXT` cluster using `SSL/SASL`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org