You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/05/16 18:27:37 UTC

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a change in pull request #716: Apps Issue #246:Replace romdisk_register() with boardctl(BOARDIOC_ROMDISK)

xiaoxiang781216 commented on a change in pull request #716:
URL: https://github.com/apache/incubator-nuttx-apps/pull/716#discussion_r633122626



##########
File path: examples/thttpd/thttpd_main.c
##########
@@ -252,12 +259,18 @@ int main(int argc, FAR char *argv[])
 
   netlib_ifup("eth0");
 
+#ifdef CONFIG_THTTPD_NXFLAT

Review comment:
       why do we need guard romfs_img registery by CONFIG_THTTPD_NXFLAT?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org