You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "Lucene/Solr QA (Jira)" <ji...@apache.org> on 2020/03/04 14:08:00 UTC

[jira] [Commented] (SOLR-9909) Nuke one of DefaultSolrThreadFactory and SolrjNamedThreadFactory

    [ https://issues.apache.org/jira/browse/SOLR-9909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17051249#comment-17051249 ] 

Lucene/Solr QA commented on SOLR-9909:
--------------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m  0s{color} | {color:green} The patch appears to include 19 new or modified test files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 35s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:red}-1{color} | {color:red} compile {color} | {color:red}  0m 43s{color} | {color:red} prometheus-exporter in the patch failed. {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red}  0m 21s{color} | {color:red} core in the patch failed. {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red}  0m 14s{color} | {color:red} test-framework in the patch failed. {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red}  0m 43s{color} | {color:red} prometheus-exporter in the patch failed. {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red}  0m 21s{color} | {color:red} core in the patch failed. {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red}  0m 14s{color} | {color:red} test-framework in the patch failed. {color} |
| {color:green}+1{color} | {color:green} Release audit (RAT) {color} | {color:green}  0m  2s{color} | {color:green} Release audit (RAT) rat-sources passed {color} |
| {color:red}-1{color} | {color:red} Release audit (RAT) {color} | {color:red}  0m  3s{color} | {color:red} prometheus-exporter in the patch failed. {color} |
| {color:red}-1{color} | {color:red} Release audit (RAT) {color} | {color:red}  0m 21s{color} | {color:red} core in the patch failed. {color} |
| {color:red}-1{color} | {color:red} Release audit (RAT) {color} | {color:red}  0m 14s{color} | {color:red} test-framework in the patch failed. {color} |
| {color:red}-1{color} | {color:red} Check forbidden APIs {color} | {color:red}  0m  2s{color} | {color:red} Check forbidden APIs check-forbidden-apis failed {color} |
| {color:red}-1{color} | {color:red} Validate source patterns {color} | {color:red}  0m  2s{color} | {color:red} Check forbidden APIs check-forbidden-apis failed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  0m  3s{color} | {color:green} tools in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}  0m 15s{color} | {color:red} prometheus-exporter in the patch failed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}  0m 16s{color} | {color:red} core in the patch failed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}  0m 15s{color} | {color:red} test-framework in the patch failed. {color} |
| {color:black}{color} | {color:black} {color} | {color:black}  5m  5s{color} | {color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | SOLR-9909 |
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12995608/SOLR-9909-02.patch |
| Optional Tests |  compile  javac  unit  ratsources  checkforbiddenapis  validatesourcepatterns  |
| uname | Linux lucene1-us-west 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | ant |
| Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-SOLR-Build/sourcedir/dev-tools/test-patch/lucene-solr-yetus-personality.sh |
| git revision | master / 46bda6bea0f |
| ant | version: Apache Ant(TM) version 1.10.5 compiled on March 28 2019 |
| Default Java | LTS |
| compile | https://builds.apache.org/job/PreCommit-SOLR-Build/695/artifact/out/patch-compile-solr_contrib_prometheus-exporter.txt |
| compile | https://builds.apache.org/job/PreCommit-SOLR-Build/695/artifact/out/patch-compile-solr_core.txt |
| compile | https://builds.apache.org/job/PreCommit-SOLR-Build/695/artifact/out/patch-compile-solr_test-framework.txt |
| javac | https://builds.apache.org/job/PreCommit-SOLR-Build/695/artifact/out/patch-compile-solr_contrib_prometheus-exporter.txt |
| javac | https://builds.apache.org/job/PreCommit-SOLR-Build/695/artifact/out/patch-compile-solr_core.txt |
| javac | https://builds.apache.org/job/PreCommit-SOLR-Build/695/artifact/out/patch-compile-solr_test-framework.txt |
| Release audit (RAT) | https://builds.apache.org/job/PreCommit-SOLR-Build/695/artifact/out/patch-compile-solr_contrib_prometheus-exporter.txt |
| Release audit (RAT) | https://builds.apache.org/job/PreCommit-SOLR-Build/695/artifact/out/patch-compile-solr_core.txt |
| Release audit (RAT) | https://builds.apache.org/job/PreCommit-SOLR-Build/695/artifact/out/patch-compile-solr_test-framework.txt |
| Check forbidden APIs | https://builds.apache.org/job/PreCommit-SOLR-Build/695/artifact/out/patch-check-forbidden-apis-root.txt |
| Validate source patterns | https://builds.apache.org/job/PreCommit-SOLR-Build/695/artifact/out/patch-check-forbidden-apis-root.txt |
| unit | https://builds.apache.org/job/PreCommit-SOLR-Build/695/artifact/out/patch-unit-solr_contrib_prometheus-exporter.txt |
| unit | https://builds.apache.org/job/PreCommit-SOLR-Build/695/artifact/out/patch-unit-solr_core.txt |
| unit | https://builds.apache.org/job/PreCommit-SOLR-Build/695/artifact/out/patch-unit-solr_test-framework.txt |
|  Test Results | https://builds.apache.org/job/PreCommit-SOLR-Build/695/testReport/ |
| modules | C: lucene/tools solr/contrib/prometheus-exporter solr/core solr/test-framework U: . |
| Console output | https://builds.apache.org/job/PreCommit-SOLR-Build/695/console |
| Powered by | Apache Yetus 0.7.0   http://yetus.apache.org |


This message was automatically generated.



> Nuke one of DefaultSolrThreadFactory and SolrjNamedThreadFactory
> ----------------------------------------------------------------
>
>                 Key: SOLR-9909
>                 URL: https://issues.apache.org/jira/browse/SOLR-9909
>             Project: Solr
>          Issue Type: Task
>            Reporter: Shalin Shekhar Mangar
>            Priority: Trivial
>             Fix For: 6.7, 7.0
>
>         Attachments: SOLR-9909-01.patch, SOLR-9909-02.patch
>
>
> DefaultSolrThreadFactory and SolrjNamedThreadFactory have exactly the same code. Let's remove one of them.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org