You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/05/19 18:39:17 UTC

[GitHub] [kafka] jlprat commented on a change in pull request #10730: KAFKA-12813: Remove Deprecated schedule method in ProcessorContext

jlprat commented on a change in pull request #10730:
URL: https://github.com/apache/kafka/pull/10730#discussion_r635494449



##########
File path: streams/test-utils/src/main/java/org/apache/kafka/streams/processor/MockProcessorContext.java
##########
@@ -450,26 +450,19 @@ public void register(final StateStore store,
         return (S) stateStores.get(name);
     }
 
+    @SuppressWarnings("deprecation") // removing #schedule(final long intervalMs,...) will fix this
     @Override
-    @Deprecated
-    public Cancellable schedule(final long intervalMs,
+    public Cancellable schedule(final Duration interval,
                                 final PunctuationType type,
-                                final Punctuator callback) {
+                                final Punctuator callback) throws IllegalArgumentException {
+        final long intervalMs = ApiUtils.validateMillisecondDuration(interval, "interval");

Review comment:
       Sure, I'll add them tomorrow morning (CEST)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org