[GitHub] [incubator-superset] villebro commented on a change in pull request #10875: refactor: ASF only dependencies on base.txt

[GitBox <gi...@apache.org>]

villebro commented on a change in pull request #10875:
URL: https://github.com/apache/incubator-superset/pull/10875#discussion_r488622476



##########
File path: requirements/development.in
##########
@@ -14,6 +14,8 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 #
+-r base.txt

Review comment:
       Why is this needed? As development dependencies might be incompatible with the pinnings in `base.txt`, this might cause a clash.

##########
File path: requirements/development.in
##########
@@ -14,6 +14,8 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 #
+-r base.txt
+-e file:.[cors,druid,hive,mysql,postgres,thumbnails]

Review comment:
       Should we add presto here?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org