You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2020/12/31 08:38:18 UTC
[GitHub] [hive] baibaichen opened a new pull request #1820: HIVE-17155: findConfFile() in HiveConf.java has some issues with the conf path
baibaichen opened a new pull request #1820:
URL: https://github.com/apache/hive/pull/1820
Cherry pick HIVE-17155 from master branch
### What changes were proposed in this pull request?
make `findConfigFile` can handle jar protocol
### Why are the changes needed?
When **spring-boot-maven-plugin** is used, we use `java -jar` to launch program, and have to use `org.springframework.boot.loader.LaunchedURLClassLoader` to load class, in such case, jar protocol is used.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
current UT
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] wangyum commented on pull request #1820: HIVE-17155: findConfFile() in HiveConf.java has some issues with the conf path
Posted by GitBox <gi...@apache.org>.
wangyum commented on pull request #1820:
URL: https://github.com/apache/hive/pull/1820#issuecomment-768872239
cc @sunchao
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] baibaichen commented on pull request #1820: HIVE-17155: findConfFile() in HiveConf.java has some issues with the conf path
Posted by GitBox <gi...@apache.org>.
baibaichen commented on pull request #1820:
URL: https://github.com/apache/hive/pull/1820#issuecomment-770180912
Thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] sunchao commented on pull request #1820: HIVE-17155: findConfFile() in HiveConf.java has some issues with the conf path
Posted by GitBox <gi...@apache.org>.
sunchao commented on pull request #1820:
URL: https://github.com/apache/hive/pull/1820#issuecomment-770159738
Yes Hive 2.3.8 is already released and Spark has upgraded to it in the master branch. This will be included in the 2.3.9 release (no date yet).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] sunchao merged pull request #1820: HIVE-17155: findConfFile() in HiveConf.java has some issues with the conf path
Posted by GitBox <gi...@apache.org>.
sunchao merged pull request #1820:
URL: https://github.com/apache/hive/pull/1820
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] baibaichen edited a comment on pull request #1820: HIVE-17155: findConfFile() in HiveConf.java has some issues with the conf path
Posted by GitBox <gi...@apache.org>.
baibaichen edited a comment on pull request #1820:
URL: https://github.com/apache/hive/pull/1820#issuecomment-770153107
@sunchao thank you for merge.
Could you please include this pr in hive 2.3.8? I think this issue is low risk, and we need it for spark 3
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] baibaichen commented on pull request #1820: HIVE-17155: findConfFile() in HiveConf.java has some issues with the conf path
Posted by GitBox <gi...@apache.org>.
baibaichen commented on pull request #1820:
URL: https://github.com/apache/hive/pull/1820#issuecomment-752916714
This PR just change initialized code path, don't know why it failed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] baibaichen commented on pull request #1820: HIVE-17155: findConfFile() in HiveConf.java has some issues with the conf path
Posted by GitBox <gi...@apache.org>.
baibaichen commented on pull request #1820:
URL: https://github.com/apache/hive/pull/1820#issuecomment-770153107
@sunchao could it be included in hive 2.3.8? I think this issue is low risk, but we need it for spark 3
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] baibaichen commented on pull request #1820: HIVE-17155: findConfFile() in HiveConf.java has some issues with the conf path
Posted by GitBox <gi...@apache.org>.
baibaichen commented on pull request #1820:
URL: https://github.com/apache/hive/pull/1820#issuecomment-752916785
retest please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] wangyum commented on pull request #1820: HIVE-17155: findConfFile() in HiveConf.java has some issues with the conf path
Posted by GitBox <gi...@apache.org>.
wangyum commented on pull request #1820:
URL: https://github.com/apache/hive/pull/1820#issuecomment-770155993
Hive 2.3.8 has been released.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org