You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/01/09 23:25:42 UTC

[GitHub] [incubator-tvm] zxy844288792 opened a new pull request #4671: [AutoTVM] Download fallback schedule file if it does not exist

zxy844288792 opened a new pull request #4671: [AutoTVM] Download fallback schedule file if it does not exist
URL: https://github.com/apache/incubator-tvm/pull/4671

Autotvm will download the default schedule file from tophub if user does not specify a schedule file. Howver, if user specifies a shedule file but a certain workload is not found in the file. It will fallback to default config, which will search the default schedule file for a closest config. However, in this case, as no schedule is downloaded from tophub, it fails to find a closest config and the performance is really bad.

An example of performance before and after is shown below:
The model is mxnet resnet50_v1 and device is NVIDIA K80 GPU

Before:
Total_time - 550853.527(us)

After:
Total_time - 28898.537(us)

Thanks for contributing to TVM! Please refer to guideline https://docs.tvm.ai/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @ them in the pull request thread.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

With regards,
Apache Git Services

[GitHub] [incubator-tvm] kevinthesun commented on issue #4671: [AutoTVM] Download fallback schedule file if it does not exist

Posted by GitBox <gi...@apache.org>.

kevinthesun commented on issue #4671: [AutoTVM] Download fallback schedule file if it does not exist
URL: https://github.com/apache/incubator-tvm/pull/4671#issuecomment-572867160
 
 
   Thanks @zxy844288792 @comaniac 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-tvm] zxy844288792 commented on a change in pull request #4671: [AutoTVM] Download fallback schedule file if it does not exist

Posted by GitBox <gi...@apache.org>.

zxy844288792 commented on a change in pull request #4671: [AutoTVM] Download fallback schedule file if it does not exist
URL: https://github.com/apache/incubator-tvm/pull/4671#discussion_r365014847
 
 

 ##########
 File path: python/tvm/autotvm/tophub.py
 ##########
 @@ -208,6 +208,10 @@ def load_reference_log(backend, model, workload_name, template_key):
     version = PACKAGE_VERSION[backend]
     package_name = "%s_%s.log" % (backend, version)
     filename = os.path.join(AUTOTVM_TOPHUB_ROOT_PATH, package_name)
+    # if fallback config file does not exist, download it from tophub
+    if not os.path.exists(filename):
 
 Review comment:
   Thanks! Comments have been addressed

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-tvm] kevinthesun merged pull request #4671: [AutoTVM] Download fallback schedule file if it does not exist

Posted by GitBox <gi...@apache.org>.

kevinthesun merged pull request #4671: [AutoTVM] Download fallback schedule file if it does not exist
URL: https://github.com/apache/incubator-tvm/pull/4671
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-tvm] CoinCheung commented on issue #4671: [AutoTVM] Download fallback schedule file if it does not exist

Posted by GitBox <gi...@apache.org>.

CoinCheung commented on issue #4671: [AutoTVM] Download fallback schedule file if it does not exist
URL: https://github.com/apache/incubator-tvm/pull/4671#issuecomment-576106701
 
 
   Hi, 
   
   Does this requires downloading from blocked websites. Do we need to download through the firewall?
   I just got the error message of: 
   ```
   download failed due to URLError(ConnectionRefusedError(111, 'Connection refused'),), retrying, 2 attempts left
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-tvm] comaniac commented on a change in pull request #4671: [AutoTVM] Download fallback schedule file if it does not exist

Posted by GitBox <gi...@apache.org>.

comaniac commented on a change in pull request #4671: [AutoTVM] Download fallback schedule file if it does not exist
URL: https://github.com/apache/incubator-tvm/pull/4671#discussion_r365012071
 
 

 ##########
 File path: python/tvm/autotvm/tophub.py
 ##########
 @@ -208,6 +208,10 @@ def load_reference_log(backend, model, workload_name, template_key):
     version = PACKAGE_VERSION[backend]
     package_name = "%s_%s.log" % (backend, version)
     filename = os.path.join(AUTOTVM_TOPHUB_ROOT_PATH, package_name)
+    # if fallback config file does not exist, download it from tophub
+    if not os.path.exists(filename):
 
 Review comment:
   It would be better to move this logic after key checking.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-tvm] comaniac commented on a change in pull request #4671: [AutoTVM] Download fallback schedule file if it does not exist

Posted by GitBox <gi...@apache.org>.

comaniac commented on a change in pull request #4671: [AutoTVM] Download fallback schedule file if it does not exist
URL: https://github.com/apache/incubator-tvm/pull/4671#discussion_r365016101
 
 

 ##########
 File path: python/tvm/autotvm/tophub.py
 ##########
 @@ -214,7 +214,12 @@ def load_reference_log(backend, model, workload_name, template_key):
 
     if key not in REFERENCE_LOG_CACHE:
         tmp = []
-        if os.path.isfile(os.path.join(AUTOTVM_TOPHUB_ROOT_PATH, package_name)):
+        # if fallback config file does not exist, download it from tophub
 
 Review comment:
   ```suggestion
           # Download the config file from tophub if not exists.
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services