[GitHub] [incubator-iceberg] SurenNihalani commented on a change in pull request #275: Fix iceberg-spark-runtime transitive dependencies.

[GitBox <gi...@apache.org>]

SurenNihalani commented on a change in pull request #275: Fix iceberg-spark-runtime transitive dependencies.
URL: https://github.com/apache/incubator-iceberg/pull/275#discussion_r302615703
 
 

 ##########
 File path: build.gradle
 ##########
 @@ -403,10 +399,13 @@ project(':iceberg-spark-runtime') {
   }
 
   dependencies {
-    compile project(':iceberg-spark')
+    compileOnly project(':iceberg-spark')
   }
 
   shadowJar {
+    // shade compileOnly dependencies to avoid including in transitive dependencies
+    configurations = [project.configurations.compileOnly]
 
 Review comment:
   I don't think this should exclude all transitive dependencies. How did we test this?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org