You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "caoliang-web (via GitHub)" <gi...@apache.org> on 2024/03/19 08:16:30 UTC
[PR] [improve](CI)Core modules require maintainer review [doris]
caoliang-web opened a new pull request, #32468:
URL: https://github.com/apache/doris/pull/32468
## Proposed changes
Issue Number: close #xxx
<!--Describe your changes.-->
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](CI)Core modules require maintainer review [doris]
Posted by "dataroaring (via GitHub)" <gi...@apache.org>.
dataroaring merged PR #32468:
URL: https://github.com/apache/doris/pull/32468
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](CI)Core modules require maintainer review [doris]
Posted by "smallhibiscus (via GitHub)" <gi...@apache.org>.
smallhibiscus commented on code in PR #32468:
URL: https://github.com/apache/doris/pull/32468#discussion_r1529980423
##########
.github/workflows/pr-approve-status.yml:
##########
@@ -19,42 +19,25 @@ name: Need_2_Approval
on:
pull_request_review:
- types: [submitted]
+ types: [ submitted ]
+
jobs:
Need_2_Approval:
runs-on: ubuntu-latest
- timeout-minutes: 3
+ timeout-minutes: 5
steps:
- uses: actions/checkout@v3
- - run: |
- pr_num=${{ github.event.pull_request.number }}
- echo $pr_num
- if [ -z "$pr_num" ]; then
- echo "PR number is not set"
- exit 1
- fi
- response=$(curl -s -H "Authorization: token ${{ secrets.GITHUB_TOKEN }} " "https://api.github.com/repos/apache/doris/pulls/${pr_num}/reviews?per_page=100")
- # shellcheck disable=SC2207
- reviewers=($(echo $response | jq -r '.[] | .user.login'))
- # shellcheck disable=SC2207
- statuses=($(echo $response | jq -r '.[] | .state'))
- echo "${reviewers[@]}"
- echo "${statuses[@]}"
- approves=()
- reviewers_unique=()
- for ((i=${#reviewers[@]}-1;i>=0;i--)); do
- if ! echo "${reviewers_unique[@]}" | grep -q -w "${reviewers[$i]}" && [ "${statuses[$i]}" != "COMMENTED" ]; then
- reviewers_unique+=( "${reviewers[$i]}" )
- if [ "${statuses[$i]}" == "APPROVED" ]; then
- approves+=( "${reviewers[$i]}" )
- fi
- fi
- done
- echo "${approves[@]}"
- if [ ${#approves[@]} -lt 2 ]; then
- echo "PR ${pr_num} has not been approved by at least 2 reviewers"
- # shellcheck disable=SC2242
- exit 1
- fi
- echo "Thanks for your contribution to Doris."
- exit 0
+ - name: Install Python dependencies
+ uses: actions/setup-python@v5
+ with:
+ python-version: '3.10' # Adjust if needed
Review Comment:
test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](CI)Core modules require maintainer review [doris]
Posted by "dataroaring (via GitHub)" <gi...@apache.org>.
dataroaring commented on PR #32468:
URL: https://github.com/apache/doris/pull/32468#issuecomment-2006491609
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](CI)Core modules require maintainer review [doris]
Posted by "gnehil (via GitHub)" <gi...@apache.org>.
gnehil commented on code in PR #32468:
URL: https://github.com/apache/doris/pull/32468#discussion_r1529963470
##########
.github/workflows/pr-approve-status.yml:
##########
@@ -19,42 +19,25 @@ name: Need_2_Approval
on:
pull_request_review:
- types: [submitted]
+ types: [ submitted ]
Review Comment:
test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](CI)Core modules require maintainer review [doris]
Posted by "dataroaring (via GitHub)" <gi...@apache.org>.
dataroaring commented on PR #32468:
URL: https://github.com/apache/doris/pull/32468#issuecomment-2058691157
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](CI)Core modules require maintainer review [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #32468:
URL: https://github.com/apache/doris/pull/32468#issuecomment-2006259256
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](CI)Core modules require maintainer review [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #32468:
URL: https://github.com/apache/doris/pull/32468#issuecomment-2006245324
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR)
Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website).
See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](CI)Core modules require maintainer review [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #32468:
URL: https://github.com/apache/doris/pull/32468#issuecomment-2006494144
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org