You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Niklas Nielsen <ni...@qni.dk> on 2015/04/03 18:59:40 UTC
Re: Review Request 30962: Enabled environment decorator to override.
> On March 30, 2015, 3:28 a.m., Adam B wrote:
> > src/hook/manager.cpp, line 130
> > <https://reviews.apache.org/r/30962/diff/5/?file=894741#file894741line130>
> >
> > And if (result.isNone()), is that really supposed to mean that this hook didn't want to modify the env, so the HookManager can leave the environment as is and move onto the next hook? If so, it's probably worth a comment, if not a LOG(INFO).
Will leave a comment for now :)
- Niklas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30962/#review78191
-----------------------------------------------------------
On March 13, 2015, 4:04 p.m., Niklas Nielsen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30962/
> -----------------------------------------------------------
>
> (Updated March 13, 2015, 4:04 p.m.)
>
>
> Review request for mesos, Ben Mahler and Kapil Arya.
>
>
> Bugs: MESOS-2351
> https://issues.apache.org/jira/browse/MESOS-2351
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary
>
>
> Diffs
> -----
>
> src/examples/test_hook_module.cpp 47409cd4d02e238d1d182571d92019114662cd41
> src/hook/manager.cpp 7a4cb09bc221af502e867cfb7fff2900b599ff1f
>
> Diff: https://reviews.apache.org/r/30962/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Niklas Nielsen
>
>