You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@auron.apache.org by "slfan1989 (via GitHub)" <gi...@apache.org> on 2026/02/10 23:59:12 UTC
[PR] [AURON #2001] Upgrade Rust nightly toolchain to 2025-06-23. [auron]
slfan1989 opened a new pull request, #2002:
URL: https://github.com/apache/auron/pull/2002
<!--
- Start the PR title with the related issue ID, e.g. '[AURON #XXXX] Short summary...'.
-->
### Which issue does this PR close?
Closes #2001
### Rationale for this change
Upgrade the Rust nightly toolchain to incorporate compiler improvements, bug fixes, and optimizations from the past 45 days (2025-05-09 to 2025-06-23).
### What changes are included in this PR?
- Update `rust-toolchain.toml`: `nightly-2025-05-09` → `nightly-2025-06-23`
- All components (rust-src, cargo, rustfmt, clippy) remain unchanged
### Are there any user-facing changes?
No.
### How was this patch tested?
CI pipeline verification
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@auron.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [AURON #2001] Upgrade Rust nightly toolchain to 2025-06-23. [auron]
Posted by "cxzl25 (via GitHub)" <gi...@apache.org>.
cxzl25 commented on PR #2002:
URL: https://github.com/apache/auron/pull/2002#issuecomment-3882783711
I remember that using `nightly-2025-06-20` would cause JVM crash. I am not sure if it has been fixed now.
https://github.com/apache/auron/pull/1126
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@auron.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [AURON #2001] Upgrade Rust nightly toolchain to 2025-12-15. [auron]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #2002:
URL: https://github.com/apache/auron/pull/2002#discussion_r2797156470
##########
rust-toolchain.toml:
##########
@@ -16,5 +16,5 @@
# under the License.
[toolchain]
-channel = "nightly-2025-05-09"
+channel = "nightly-2025-12-15"
components = ["rust-src", "cargo", "rustfmt", "clippy"]
Review Comment:
The PR description says this change only updates `rust-toolchain.toml`, but this PR also includes multiple code edits across `native-engine/*` (let-chains refactors, `std::slice::from_ref` changes, `xxh_rotl64` implementation change, etc.). Please update the PR description/rationale to accurately reflect these additional changes (and the actual upgrade window; 2025-05-09 → 2025-12-15 is ~220 days, not 45).
##########
native-engine/datafusion-ext-functions/src/spark_get_json_object.rs:
##########
@@ -305,15 +305,15 @@ impl HiveGetJsonObjectEvaluator {
json_str: &str,
) -> std::result::Result<Option<String>, HiveGetJsonObjectError> {
// first try parsing with sonic-rs and fail-backing to serde-json
Review Comment:
Typo in comment: "fail-backing" should be "falling back" (or "falling back to serde-json").
```suggestion
// first try parsing with sonic-rs and falling back to serde-json
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@auron.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [AURON #2001] Upgrade Rust nightly toolchain to 2025-12-15. [auron]
Posted by "SteNicholas (via GitHub)" <gi...@apache.org>.
SteNicholas closed pull request #2002: [AURON #2001] Upgrade Rust nightly toolchain to 2025-12-15.
URL: https://github.com/apache/auron/pull/2002
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@auron.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [AURON #2001] Upgrade Rust nightly toolchain to 2025-06-23. [auron]
Posted by "slfan1989 (via GitHub)" <gi...@apache.org>.
slfan1989 commented on PR #2002:
URL: https://github.com/apache/auron/pull/2002#issuecomment-3884524421
> i suggest to use a more recent nightly version (if it works)
Thanks for the suggestion! I’ll try a more recent nightly version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@auron.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [AURON #2001] Upgrade Rust nightly toolchain to 2025-12-15. [auron]
Posted by "slfan1989 (via GitHub)" <gi...@apache.org>.
slfan1989 commented on PR #2002:
URL: https://github.com/apache/auron/pull/2002#issuecomment-3887293048
@cxzl25 @richox Based on our testing, we can upgrade to a newer version. Would it be okay to use the 2025-12-15 release?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@auron.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [AURON #2001] Upgrade Rust nightly toolchain to 2025-06-23. [auron]
Posted by "slfan1989 (via GitHub)" <gi...@apache.org>.
slfan1989 commented on PR #2002:
URL: https://github.com/apache/auron/pull/2002#issuecomment-3882826575
> I remember that using `nightly-2025-06-20` would cause JVM crash. I am not sure if it has been fixed now.
>
> #1126
@cxzl25 Thank you so much for the reply! I tried searching for it, but couldn’t find any information about a JVM crash caused on 2025-06-20. However, Iceberg-Rust is already using 2025-06-23. Should we give it a try?
https://github.com/apache/iceberg-rust/blob/main/rust-toolchain.toml
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@auron.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [AURON #2001] Upgrade Rust nightly toolchain to 2025-12-15. [auron]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #2002:
URL: https://github.com/apache/auron/pull/2002#discussion_r2796725570
##########
rust-toolchain.toml:
##########
@@ -16,5 +16,5 @@
# under the License.
[toolchain]
-channel = "nightly-2025-05-09"
+channel = "nightly-2025-12-15"
Review Comment:
The PR description states the upgrade is for "the past 45 days (2025-05-09 to 2025-12-15)", but the time span from May 9 to December 15, 2025 is approximately 220 days (about 7 months), not 45 days. Additionally, the linked issue #2001 mentions upgrading to "nightly-2025-06-23" (which would indeed be about 45 days from May 9), but the actual version being used here is "nightly-2025-12-15". Please verify which version is intended and correct the PR description accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@auron.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [AURON #2001] Upgrade Rust nightly toolchain to 2025-06-23. [auron]
Posted by "slfan1989 (via GitHub)" <gi...@apache.org>.
slfan1989 commented on PR #2002:
URL: https://github.com/apache/auron/pull/2002#issuecomment-3882593250
@cxzl25 @richox Could you please review this PR? Thanks a lot!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@auron.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [AURON #2001] Upgrade Rust nightly toolchain to 2025-06-23. [auron]
Posted by "richox (via GitHub)" <gi...@apache.org>.
richox commented on PR #2002:
URL: https://github.com/apache/auron/pull/2002#issuecomment-3884505810
i suggest to use a more recent nightly version (if it works)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@auron.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org