You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Bannier <be...@mesosphere.io> on 2016/04/05 18:01:21 UTC
Review Request 45749: Adjusted lifetimes of member variables.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45749/
-----------------------------------------------------------
Review request for mesos, Joseph Wu and Michael Park.
Bugs: MESOS-5000
https://issues.apache.org/jira/browse/MESOS-5000
Repository: mesos
Description
-------
This correctly reflects the lifetime dependencies among
Master::storage, Master::state and Master::registrar.
Diffs
-----
src/tests/cluster.hpp 91d3998176115002ea22a0825b1aaaee3fe0d768
Diff: https://reviews.apache.org/r/45749/diff/
Testing
-------
Without this patch e.g., `MasterTest.MasterLost` fails under OS X with clang (trunk, not optimized), and `ResourceOffersTest.ResourceOfferWithMultipleSlaves` fails under Ubuntu14.04 with stock gcc (not optimized). With this patch they can be executed without failure a couple thousand times.
Thanks,
Benjamin Bannier
Re: Review Request 45749: Adjusted lifetimes of member variables.
Posted by Michael Park <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45749/#review127421
-----------------------------------------------------------
Ship it!
Ship It!
- Michael Park
On April 5, 2016, 4:01 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45749/
> -----------------------------------------------------------
>
> (Updated April 5, 2016, 4:01 p.m.)
>
>
> Review request for mesos, Joseph Wu and Michael Park.
>
>
> Bugs: MESOS-5000
> https://issues.apache.org/jira/browse/MESOS-5000
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This correctly reflects the lifetime dependencies among
> Master::storage, Master::state and Master::registrar.
>
>
> Diffs
> -----
>
> src/tests/cluster.hpp 91d3998176115002ea22a0825b1aaaee3fe0d768
>
> Diff: https://reviews.apache.org/r/45749/diff/
>
>
> Testing
> -------
>
> Without this patch e.g., `MasterTest.MasterLost` fails under OS X with clang (trunk, not optimized), and `ResourceOffersTest.ResourceOfferWithMultipleSlaves` fails under Ubuntu14.04 with stock gcc (not optimized). With this patch they can be executed without failure a couple thousand times.
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 45749: Adjusted lifetimes of member variables.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45749/#review127157
-----------------------------------------------------------
Patch looks great!
Reviews applied: [45749]
Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On April 5, 2016, 4:01 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45749/
> -----------------------------------------------------------
>
> (Updated April 5, 2016, 4:01 p.m.)
>
>
> Review request for mesos, Joseph Wu and Michael Park.
>
>
> Bugs: MESOS-5000
> https://issues.apache.org/jira/browse/MESOS-5000
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This correctly reflects the lifetime dependencies among
> Master::storage, Master::state and Master::registrar.
>
>
> Diffs
> -----
>
> src/tests/cluster.hpp 91d3998176115002ea22a0825b1aaaee3fe0d768
>
> Diff: https://reviews.apache.org/r/45749/diff/
>
>
> Testing
> -------
>
> Without this patch e.g., `MasterTest.MasterLost` fails under OS X with clang (trunk, not optimized), and `ResourceOffersTest.ResourceOfferWithMultipleSlaves` fails under Ubuntu14.04 with stock gcc (not optimized). With this patch they can be executed without failure a couple thousand times.
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 45749: Adjusted lifetimes of member variables.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45749/#review127165
-----------------------------------------------------------
Ship it!
Ship It!
- Joseph Wu
On April 5, 2016, 9:01 a.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45749/
> -----------------------------------------------------------
>
> (Updated April 5, 2016, 9:01 a.m.)
>
>
> Review request for mesos, Joseph Wu and Michael Park.
>
>
> Bugs: MESOS-5000
> https://issues.apache.org/jira/browse/MESOS-5000
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This correctly reflects the lifetime dependencies among
> Master::storage, Master::state and Master::registrar.
>
>
> Diffs
> -----
>
> src/tests/cluster.hpp 91d3998176115002ea22a0825b1aaaee3fe0d768
>
> Diff: https://reviews.apache.org/r/45749/diff/
>
>
> Testing
> -------
>
> Without this patch e.g., `MasterTest.MasterLost` fails under OS X with clang (trunk, not optimized), and `ResourceOffersTest.ResourceOfferWithMultipleSlaves` fails under Ubuntu14.04 with stock gcc (not optimized). With this patch they can be executed without failure a couple thousand times.
>
>
> Thanks,
>
> Benjamin Bannier
>
>