You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/01/16 14:46:11 UTC
[GitHub] [flink] leonardBang opened a new pull request #10874:
[FLINK-15552][table api] parameters --library and --jar doesn't work for
DDL in sqlClient
leonardBang opened a new pull request #10874: [FLINK-15552][table api] parameters --library and --jar doesn't work for DDL in sqlClient
URL: https://github.com/apache/flink/pull/10874
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Travis CI to do that following [this guide](https://flink.apache.org/contributing/contribute-code.html#open-a-pull-request).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
*This pull request use current classloader to load classes which fix parameters --library adn --jar in sqlClient can not play correctly .*
## Brief change log
- *update file org/apache/flink/table/factories/TableFactoryService.java*
## Verifying this change
This change is a trivial rework without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): ( no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10874:
[FLINK-15552][table api] parameters --library and --jar doesn't work for
DDL in sqlClient
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10874: [FLINK-15552][table api] parameters --library and --jar doesn't work for DDL in sqlClient
URL: https://github.com/apache/flink/pull/10874#issuecomment-575202836
<!--
Meta data
Hash:d55a80e9da0760f4a1d39ff60f50ac9cb8e40557 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4411 TriggerType:PUSH TriggerID:d55a80e9da0760f4a1d39ff60f50ac9cb8e40557
Hash:d55a80e9da0760f4a1d39ff60f50ac9cb8e40557 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/144760039 TriggerType:PUSH TriggerID:d55a80e9da0760f4a1d39ff60f50ac9cb8e40557
Hash:c956c947157110421ea2a1f29f1d0d67040875cd Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/144902078 TriggerType:PUSH TriggerID:c956c947157110421ea2a1f29f1d0d67040875cd
Hash:c956c947157110421ea2a1f29f1d0d67040875cd Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4426 TriggerType:PUSH TriggerID:c956c947157110421ea2a1f29f1d0d67040875cd
Hash:0012c39e883a1d1685dd1f09d08d460370b82151 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/144911867 TriggerType:PUSH TriggerID:0012c39e883a1d1685dd1f09d08d460370b82151
Hash:0012c39e883a1d1685dd1f09d08d460370b82151 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4432 TriggerType:PUSH TriggerID:0012c39e883a1d1685dd1f09d08d460370b82151
-->
## CI report:
* d55a80e9da0760f4a1d39ff60f50ac9cb8e40557 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/144760039) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4411)
* c956c947157110421ea2a1f29f1d0d67040875cd Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/144902078) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4426)
* 0012c39e883a1d1685dd1f09d08d460370b82151 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144911867) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4432)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] aljoscha commented on a change in pull request #10874:
[FLINK-15552][table api] parameters --library and --jar doesn't work for
DDL in sqlClient
Posted by GitBox <gi...@apache.org>.
aljoscha commented on a change in pull request #10874: [FLINK-15552][table api] parameters --library and --jar doesn't work for DDL in sqlClient
URL: https://github.com/apache/flink/pull/10874#discussion_r369556795
##########
File path: flink-scala-shell/src/test/scala/org/apache/flink/api/scala/ScalaShellITCase.scala
##########
@@ -43,6 +43,13 @@ class ScalaShellITCase extends TestLogger {
@Rule
def temporaryFolder = _temporaryFolder
+ @After
+ def resetClassLoder(): Unit = {
+ // The Scala interpreter changes current class loader to ScalaClassLoader in every execution
+ // refer to [[ILoop.process()]]. So, we need reset it to original class loader after every Test.
+ Thread.currentThread().setContextClassLoader(classOf[ScalaShellITCase].getClassLoader)
Review comment:
The basic change makes sense, yes. But why doesn't it work if we only reset it after all tests? Is it because there are multiple tests where the scala shell test uses the table environment?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] wuchong commented on a change in pull request #10874:
[FLINK-15552][table api] parameters --library and --jar doesn't work for
DDL in sqlClient
Posted by GitBox <gi...@apache.org>.
wuchong commented on a change in pull request #10874: [FLINK-15552][table api] parameters --library and --jar doesn't work for DDL in sqlClient
URL: https://github.com/apache/flink/pull/10874#discussion_r368264530
##########
File path: flink-scala-shell/src/test/scala/org/apache/flink/api/scala/ScalaShellITCase.scala
##########
@@ -43,6 +43,13 @@ class ScalaShellITCase extends TestLogger {
@Rule
def temporaryFolder = _temporaryFolder
+ @After
+ def resetClassLoder(): Unit = {
+ // The Scala interpreter changes current class loader to ScalaClassLoader in every execution
+ // refer to [[ILoop.process()]]. So, we need reset it to original class loader after every Test.
+ Thread.currentThread().setContextClassLoader(classOf[ScalaShellITCase].getClassLoader)
Review comment:
This resets classloader after each tests instead of after class. Because `TableFactoryService` relies to the correct thread context class loader now. Does this make sense to you @twalthr @aljoscha ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] wuchong commented on a change in pull request #10874:
[FLINK-15552][table api] parameters --library and --jar doesn't work for
DDL in sqlClient
Posted by GitBox <gi...@apache.org>.
wuchong commented on a change in pull request #10874: [FLINK-15552][table api] parameters --library and --jar doesn't work for DDL in sqlClient
URL: https://github.com/apache/flink/pull/10874#discussion_r367738744
##########
File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/factories/TableFactoryService.java
##########
@@ -214,7 +213,10 @@
.iterator()
.forEachRemaining(result::add);
} else {
- defaultLoader.iterator().forEachRemaining(result::add);
+ ServiceLoader
+ .load(TableFactory.class, Thread.currentThread().getContextClassLoader())
+ .iterator()
+ .forEachRemaining(result::add);
}
Review comment:
We can simplify it a bit more:
```java
ClassLoader cl = classLoader.orElse(Thread.currentThread().getContextClassLoader());
ServiceLoader
.load(TableFactory.class, cl)
.iterator()
.forEachRemaining(result::add);
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] leonardBang commented on a change in pull request #10874:
[FLINK-15552][table api] parameters --library and --jar doesn't work for
DDL in sqlClient
Posted by GitBox <gi...@apache.org>.
leonardBang commented on a change in pull request #10874: [FLINK-15552][table api] parameters --library and --jar doesn't work for DDL in sqlClient
URL: https://github.com/apache/flink/pull/10874#discussion_r367740553
##########
File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/factories/TableFactoryService.java
##########
@@ -214,7 +213,10 @@
.iterator()
.forEachRemaining(result::add);
} else {
- defaultLoader.iterator().forEachRemaining(result::add);
+ ServiceLoader
+ .load(TableFactory.class, Thread.currentThread().getContextClassLoader())
+ .iterator()
+ .forEachRemaining(result::add);
}
Review comment:
nice tips
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10874:
[FLINK-15552][table api] parameters --library and --jar doesn't work for
DDL in sqlClient
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10874: [FLINK-15552][table api] parameters --library and --jar doesn't work for DDL in sqlClient
URL: https://github.com/apache/flink/pull/10874#issuecomment-575202836
<!--
Meta data
Hash:d55a80e9da0760f4a1d39ff60f50ac9cb8e40557 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4411 TriggerType:PUSH TriggerID:d55a80e9da0760f4a1d39ff60f50ac9cb8e40557
Hash:d55a80e9da0760f4a1d39ff60f50ac9cb8e40557 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/144760039 TriggerType:PUSH TriggerID:d55a80e9da0760f4a1d39ff60f50ac9cb8e40557
Hash:c956c947157110421ea2a1f29f1d0d67040875cd Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/144902078 TriggerType:PUSH TriggerID:c956c947157110421ea2a1f29f1d0d67040875cd
Hash:c956c947157110421ea2a1f29f1d0d67040875cd Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4426 TriggerType:PUSH TriggerID:c956c947157110421ea2a1f29f1d0d67040875cd
-->
## CI report:
* d55a80e9da0760f4a1d39ff60f50ac9cb8e40557 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/144760039) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4411)
* c956c947157110421ea2a1f29f1d0d67040875cd Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/144902078) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4426)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10874:
[FLINK-15552][table api] parameters --library and --jar doesn't work for
DDL in sqlClient
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10874: [FLINK-15552][table api] parameters --library and --jar doesn't work for DDL in sqlClient
URL: https://github.com/apache/flink/pull/10874#issuecomment-575202836
<!--
Meta data
Hash:d55a80e9da0760f4a1d39ff60f50ac9cb8e40557 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4411 TriggerType:PUSH TriggerID:d55a80e9da0760f4a1d39ff60f50ac9cb8e40557
Hash:d55a80e9da0760f4a1d39ff60f50ac9cb8e40557 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/144760039 TriggerType:PUSH TriggerID:d55a80e9da0760f4a1d39ff60f50ac9cb8e40557
-->
## CI report:
* d55a80e9da0760f4a1d39ff60f50ac9cb8e40557 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/144760039) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4411)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] wuchong commented on a change in pull request #10874:
[FLINK-15552][table api] parameters --library and --jar doesn't work for
DDL in sqlClient
Posted by GitBox <gi...@apache.org>.
wuchong commented on a change in pull request #10874: [FLINK-15552][table api] parameters --library and --jar doesn't work for DDL in sqlClient
URL: https://github.com/apache/flink/pull/10874#discussion_r369595211
##########
File path: flink-scala-shell/src/test/scala/org/apache/flink/api/scala/ScalaShellITCase.scala
##########
@@ -43,6 +43,13 @@ class ScalaShellITCase extends TestLogger {
@Rule
def temporaryFolder = _temporaryFolder
+ @After
+ def resetClassLoder(): Unit = {
+ // The Scala interpreter changes current class loader to ScalaClassLoader in every execution
+ // refer to [[ILoop.process()]]. So, we need reset it to original class loader after every Test.
+ Thread.currentThread().setContextClassLoader(classOf[ScalaShellITCase].getClassLoader)
Review comment:
Yes, there are multiple Table API tests in it. Because the thread's classloader will be set to `ScalaClassLoader` in each test, and `TableFactoryService` can't find the correct factory from `ScalaClassLoader`, that's why we have to reset thread's classloader after each test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10874:
[FLINK-15552][table api] parameters --library and --jar doesn't work for
DDL in sqlClient
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10874: [FLINK-15552][table api] parameters --library and --jar doesn't work for DDL in sqlClient
URL: https://github.com/apache/flink/pull/10874#issuecomment-575202836
<!--
Meta data
Hash:d55a80e9da0760f4a1d39ff60f50ac9cb8e40557 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4411 TriggerType:PUSH TriggerID:d55a80e9da0760f4a1d39ff60f50ac9cb8e40557
Hash:d55a80e9da0760f4a1d39ff60f50ac9cb8e40557 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/144760039 TriggerType:PUSH TriggerID:d55a80e9da0760f4a1d39ff60f50ac9cb8e40557
-->
## CI report:
* d55a80e9da0760f4a1d39ff60f50ac9cb8e40557 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/144760039) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4411)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10874:
[FLINK-15552][table api] parameters --library and --jar doesn't work for
DDL in sqlClient
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10874: [FLINK-15552][table api] parameters --library and --jar doesn't work for DDL in sqlClient
URL: https://github.com/apache/flink/pull/10874#issuecomment-575202836
<!--
Meta data
Hash:d55a80e9da0760f4a1d39ff60f50ac9cb8e40557 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4411 TriggerType:PUSH TriggerID:d55a80e9da0760f4a1d39ff60f50ac9cb8e40557
Hash:d55a80e9da0760f4a1d39ff60f50ac9cb8e40557 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/144760039 TriggerType:PUSH TriggerID:d55a80e9da0760f4a1d39ff60f50ac9cb8e40557
Hash:c956c947157110421ea2a1f29f1d0d67040875cd Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/144902078 TriggerType:PUSH TriggerID:c956c947157110421ea2a1f29f1d0d67040875cd
Hash:c956c947157110421ea2a1f29f1d0d67040875cd Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4426 TriggerType:PUSH TriggerID:c956c947157110421ea2a1f29f1d0d67040875cd
Hash:0012c39e883a1d1685dd1f09d08d460370b82151 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:0012c39e883a1d1685dd1f09d08d460370b82151
-->
## CI report:
* d55a80e9da0760f4a1d39ff60f50ac9cb8e40557 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/144760039) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4411)
* c956c947157110421ea2a1f29f1d0d67040875cd Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/144902078) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4426)
* 0012c39e883a1d1685dd1f09d08d460370b82151 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10874:
[FLINK-15552][table api] parameters --library and --jar doesn't work for
DDL in sqlClient
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10874: [FLINK-15552][table api] parameters --library and --jar doesn't work for DDL in sqlClient
URL: https://github.com/apache/flink/pull/10874#issuecomment-575202836
<!--
Meta data
Hash:d55a80e9da0760f4a1d39ff60f50ac9cb8e40557 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4411 TriggerType:PUSH TriggerID:d55a80e9da0760f4a1d39ff60f50ac9cb8e40557
Hash:d55a80e9da0760f4a1d39ff60f50ac9cb8e40557 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/144760039 TriggerType:PUSH TriggerID:d55a80e9da0760f4a1d39ff60f50ac9cb8e40557
Hash:c956c947157110421ea2a1f29f1d0d67040875cd Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/144902078 TriggerType:PUSH TriggerID:c956c947157110421ea2a1f29f1d0d67040875cd
Hash:c956c947157110421ea2a1f29f1d0d67040875cd Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4426 TriggerType:PUSH TriggerID:c956c947157110421ea2a1f29f1d0d67040875cd
Hash:0012c39e883a1d1685dd1f09d08d460370b82151 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/144911867 TriggerType:PUSH TriggerID:0012c39e883a1d1685dd1f09d08d460370b82151
Hash:0012c39e883a1d1685dd1f09d08d460370b82151 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4432 TriggerType:PUSH TriggerID:0012c39e883a1d1685dd1f09d08d460370b82151
-->
## CI report:
* d55a80e9da0760f4a1d39ff60f50ac9cb8e40557 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/144760039) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4411)
* c956c947157110421ea2a1f29f1d0d67040875cd Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/144902078) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4426)
* 0012c39e883a1d1685dd1f09d08d460370b82151 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/144911867) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4432)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10874: [FLINK-15552][table
api] parameters --library and --jar doesn't work for DDL in sqlClient
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10874: [FLINK-15552][table api] parameters --library and --jar doesn't work for DDL in sqlClient
URL: https://github.com/apache/flink/pull/10874#issuecomment-575202836
<!--
Meta data
Hash:d55a80e9da0760f4a1d39ff60f50ac9cb8e40557 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:d55a80e9da0760f4a1d39ff60f50ac9cb8e40557
-->
## CI report:
* d55a80e9da0760f4a1d39ff60f50ac9cb8e40557 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] wuchong merged pull request #10874: [FLINK-15552][table
api] parameters --library and --jar doesn't work for DDL in sqlClient
Posted by GitBox <gi...@apache.org>.
wuchong merged pull request #10874: [FLINK-15552][table api] parameters --library and --jar doesn't work for DDL in sqlClient
URL: https://github.com/apache/flink/pull/10874
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10874:
[FLINK-15552][table api] parameters --library and --jar doesn't work for
DDL in sqlClient
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10874: [FLINK-15552][table api] parameters --library and --jar doesn't work for DDL in sqlClient
URL: https://github.com/apache/flink/pull/10874#issuecomment-575202836
<!--
Meta data
Hash:d55a80e9da0760f4a1d39ff60f50ac9cb8e40557 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4411 TriggerType:PUSH TriggerID:d55a80e9da0760f4a1d39ff60f50ac9cb8e40557
Hash:d55a80e9da0760f4a1d39ff60f50ac9cb8e40557 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/144760039 TriggerType:PUSH TriggerID:d55a80e9da0760f4a1d39ff60f50ac9cb8e40557
Hash:c956c947157110421ea2a1f29f1d0d67040875cd Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/144902078 TriggerType:PUSH TriggerID:c956c947157110421ea2a1f29f1d0d67040875cd
Hash:c956c947157110421ea2a1f29f1d0d67040875cd Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4426 TriggerType:PUSH TriggerID:c956c947157110421ea2a1f29f1d0d67040875cd
Hash:0012c39e883a1d1685dd1f09d08d460370b82151 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/144911867 TriggerType:PUSH TriggerID:0012c39e883a1d1685dd1f09d08d460370b82151
Hash:0012c39e883a1d1685dd1f09d08d460370b82151 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4432 TriggerType:PUSH TriggerID:0012c39e883a1d1685dd1f09d08d460370b82151
-->
## CI report:
* d55a80e9da0760f4a1d39ff60f50ac9cb8e40557 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/144760039) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4411)
* c956c947157110421ea2a1f29f1d0d67040875cd Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/144902078) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4426)
* 0012c39e883a1d1685dd1f09d08d460370b82151 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144911867) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4432)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10874: [FLINK-15552][table
api] parameters --library and --jar doesn't work for DDL in sqlClient
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10874: [FLINK-15552][table api] parameters --library and --jar doesn't work for DDL in sqlClient
URL: https://github.com/apache/flink/pull/10874#issuecomment-575185801
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit d55a80e9da0760f4a1d39ff60f50ac9cb8e40557 (Thu Jan 16 14:49:49 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10874:
[FLINK-15552][table api] parameters --library and --jar doesn't work for
DDL in sqlClient
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10874: [FLINK-15552][table api] parameters --library and --jar doesn't work for DDL in sqlClient
URL: https://github.com/apache/flink/pull/10874#issuecomment-575202836
<!--
Meta data
Hash:d55a80e9da0760f4a1d39ff60f50ac9cb8e40557 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4411 TriggerType:PUSH TriggerID:d55a80e9da0760f4a1d39ff60f50ac9cb8e40557
Hash:d55a80e9da0760f4a1d39ff60f50ac9cb8e40557 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/144760039 TriggerType:PUSH TriggerID:d55a80e9da0760f4a1d39ff60f50ac9cb8e40557
Hash:c956c947157110421ea2a1f29f1d0d67040875cd Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:c956c947157110421ea2a1f29f1d0d67040875cd
-->
## CI report:
* d55a80e9da0760f4a1d39ff60f50ac9cb8e40557 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/144760039) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4411)
* c956c947157110421ea2a1f29f1d0d67040875cd UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services