[GitHub] [orc] noirello commented on a change in pull request #959: ORC-1047: [C++] Handle quoted field names during string schema parsing

[GitBox <gi...@apache.org>]

noirello commented on a change in pull request #959:
URL: https://github.com/apache/orc/pull/959#discussion_r744532862



##########
File path: c++/src/TypeImpl.cc
##########
@@ -218,7 +227,19 @@ namespace orc {
         if (i != 0) {
           result += ",";
         }
-        result += fieldNames[i];
+        if (isUnquotedFieldName(fieldNames[i])) {
+          result += fieldNames[i];
+        } else {
+          std::string name(fieldNames[i]);
+          size_t pos = 0;
+          while ((pos = name.find("`", pos)) != std::string::npos) {
+            name.replace(pos, 1, "``");

Review comment:
       I'm not sure I understand. Could you give me an example? 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org