You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by Prasad Mujumdar <pr...@cloudera.com> on 2012/03/30 07:33:54 UTC
Review Request: FLUME-1074: AvroSink if any non-caught exception is thrown,
an exception is thrown in finally clause
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4568/
-----------------------------------------------------------
Review request for Flume, Arvind Prabhakar and Mike Percy.
Summary
-------
Add exception handlers to rollback open transactions in error cases.
This addresses bug FLUME-1074.
https://issues.apache.org/jira/browse/FLUME-1074
Diffs
-----
flume-ng-core/src/main/java/org/apache/flume/channel/ChannelProcessor.java 7e24e32
flume-ng-core/src/main/java/org/apache/flume/sink/AvroSink.java e231cb8
Diff: https://reviews.apache.org/r/4568/diff
Testing
-------
regression test run
Thanks,
Prasad
Re: Review Request: FLUME-1074: AvroSink if any non-caught exception is
thrown, an exception is thrown in finally clause
Posted by Mike Percy <mp...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4568/#review6569
-----------------------------------------------------------
Prasad, good catch. These are the only two places with a Transaction.commit() and without a catch (Exception e) clause.
Looks good to me.
- Mike
On 2012-03-30 05:33:54, Prasad Mujumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4568/
> -----------------------------------------------------------
>
> (Updated 2012-03-30 05:33:54)
>
>
> Review request for Flume, Arvind Prabhakar and Mike Percy.
>
>
> Summary
> -------
>
> Add exception handlers to rollback open transactions in error cases.
>
>
> This addresses bug FLUME-1074.
> https://issues.apache.org/jira/browse/FLUME-1074
>
>
> Diffs
> -----
>
> flume-ng-core/src/main/java/org/apache/flume/channel/ChannelProcessor.java 7e24e32
> flume-ng-core/src/main/java/org/apache/flume/sink/AvroSink.java e231cb8
>
> Diff: https://reviews.apache.org/r/4568/diff
>
>
> Testing
> -------
>
> regression test run
>
>
> Thanks,
>
> Prasad
>
>
Re: Review Request: FLUME-1074: AvroSink if any non-caught exception is
thrown, an exception is thrown in finally clause
Posted by Arvind Prabhakar <ar...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4568/#review6578
-----------------------------------------------------------
Ship it!
+1
Thanks for the patch Prasad, please attach it to the Jira.
- Arvind
On 2012-03-30 05:33:54, Prasad Mujumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4568/
> -----------------------------------------------------------
>
> (Updated 2012-03-30 05:33:54)
>
>
> Review request for Flume, Arvind Prabhakar and Mike Percy.
>
>
> Summary
> -------
>
> Add exception handlers to rollback open transactions in error cases.
>
>
> This addresses bug FLUME-1074.
> https://issues.apache.org/jira/browse/FLUME-1074
>
>
> Diffs
> -----
>
> flume-ng-core/src/main/java/org/apache/flume/channel/ChannelProcessor.java 7e24e32
> flume-ng-core/src/main/java/org/apache/flume/sink/AvroSink.java e231cb8
>
> Diff: https://reviews.apache.org/r/4568/diff
>
>
> Testing
> -------
>
> regression test run
>
>
> Thanks,
>
> Prasad
>
>