[GitHub] [incubator-nuttx] yamt commented on pull request #3995: fix active close for CONFIG_NET_TCP_WRITE_BUFFERS

[GitBox <gi...@apache.org>]

yamt commented on pull request #3995:
URL: https://github.com/apache/incubator-nuttx/pull/3995#issuecomment-871890375


   > > > > However, I noticed that we still have the same RST issue for the passive close case.
   > > > > In this case, the issue happens for both CONFIG_NET_TCP_WRITE_BUFFERS=y and n.
   > > > 
   > > > 
   > > > i couldn't reproduce it.
   > > > i connected to telnetd (nuttx) using telnet (netbsd) and then disconnect it with ^[ q.
   > > 
   > > 
   > > @yamt
   > > Oh, really?
   > > I tried the same procedure with the telnet client on both Ubuntu 18.04 (x86_64) and macOS 11.4 (x86_64) and I can see the NuttX finally sends an RST/ACK packet after received ACK from the telnet client.
   > > <img alt="nuttx-tcp-passive-close-20210701" width="1149" src="https://user-images.githubusercontent.com/25843920/124039028-18457f00-da3d-11eb-838e-59de95e5c820.png">
   > 
   > i guess it depends on the timing.
   > as tcp_close() disposes non ESTABLISHED connection immediately, if the app close() the socket before the last ACK arrives, we respond with a RST.
   
   i implemented a fix.
   https://github.com/apache/incubator-nuttx/pull/3991
   "tcp_close: Fix a race with passive close" commit
   
   i will submit a separate PR after testing a bit more.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org