You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Mahler <bm...@apache.org> on 2017/03/16 22:47:03 UTC
Review Request 57707: Added multi-role framework support to the
CHANGELOG.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57707/
-----------------------------------------------------------
Review request for mesos, Michael Park and Vinod Kone.
Bugs: MESOS-6762
https://issues.apache.org/jira/browse/MESOS-6762
Repository: mesos
Description
-------
Added multi-role framework support to the CHANGELOG.
Diffs
-----
CHANGELOG 0a4e1dd52f9197151c5ef4318579ffa4e9bcf0ee
Diff: https://reviews.apache.org/r/57707/diff/1/
Testing
-------
N/A
Thanks,
Benjamin Mahler
Re: Review Request 57707: Added multi-role framework support to the
CHANGELOG.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57707/#review169252
-----------------------------------------------------------
Patch looks great!
Reviews applied: [57707]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On March 16, 2017, 10:47 p.m., Benjamin Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57707/
> -----------------------------------------------------------
>
> (Updated March 16, 2017, 10:47 p.m.)
>
>
> Review request for mesos, Michael Park and Vinod Kone.
>
>
> Bugs: MESOS-6762
> https://issues.apache.org/jira/browse/MESOS-6762
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added multi-role framework support to the CHANGELOG.
>
>
> Diffs
> -----
>
> CHANGELOG 0a4e1dd52f9197151c5ef4318579ffa4e9bcf0ee
>
>
> Diff: https://reviews.apache.org/r/57707/diff/1/
>
>
> Testing
> -------
>
> N/A
>
>
> Thanks,
>
> Benjamin Mahler
>
>
Re: Review Request 57707: Added multi-role framework support to the
CHANGELOG.
Posted by Michael Park <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57707/#review169912
-----------------------------------------------------------
Fix it, then Ship it!
CHANGELOG
Lines 7 (patched)
<https://reviews.apache.org/r/57707/#comment242621>
`s/one has to/one had to/`?
CHANGELOG
Lines 8 (patched)
<https://reviews.apache.org/r/57707/#comment242620>
- `multiple instances of a single-tenant framework`?
- `s/acheive/achieve/`
- Michael Park
On March 16, 2017, 3:47 p.m., Benjamin Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57707/
> -----------------------------------------------------------
>
> (Updated March 16, 2017, 3:47 p.m.)
>
>
> Review request for mesos, Michael Park and Vinod Kone.
>
>
> Bugs: MESOS-6762
> https://issues.apache.org/jira/browse/MESOS-6762
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added multi-role framework support to the CHANGELOG.
>
>
> Diffs
> -----
>
> CHANGELOG 0a4e1dd52f9197151c5ef4318579ffa4e9bcf0ee
>
>
> Diff: https://reviews.apache.org/r/57707/diff/1/
>
>
> Testing
> -------
>
> N/A
>
>
> Thanks,
>
> Benjamin Mahler
>
>