You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/09/07 04:48:25 UTC
[GitHub] [shardingsphere] strongduanmu commented on a diff in pull request #20778: [Issue #19262]-Assertions added for metadata in MetaDataContextsFactory test
strongduanmu commented on code in PR #20778:
URL: https://github.com/apache/shardingsphere/pull/20778#discussion_r964376418
##########
shardingsphere-mode/shardingsphere-mode-core/src/test/java/org/apache/shardingsphere/mode/metadata/MetaDataContextsFactoryTest.java:
##########
@@ -53,18 +70,57 @@ public final class MetaDataContextsFactoryTest {
@Mock
private DatabaseMetaDataPersistService databaseMetaDataPersistService;
-
+
+ @Mock
+ private ShardingSphereDatabase mockShardingSphereDb;
Review Comment:
Do you think database is better?
##########
shardingsphere-mode/shardingsphere-mode-core/src/test/java/org/apache/shardingsphere/mode/metadata/MetaDataContextsFactoryTest.java:
##########
@@ -53,18 +70,57 @@ public final class MetaDataContextsFactoryTest {
@Mock
private DatabaseMetaDataPersistService databaseMetaDataPersistService;
-
+
+ @Mock
+ private ShardingSphereDatabase mockShardingSphereDb;
+
+ @Mock
+ private JDBCInstanceMetaData jdbcInstanceMetaData;
+
+ private final Properties properties = new Properties();
+
+ private final List<ShardingSphereRule> shardingSphereRules = new ArrayList<ShardingSphereRule>() {
Review Comment:
Please use Collection<ShardingSphereRule> instead of List<ShardingSphereRule>.
##########
shardingsphere-mode/shardingsphere-mode-core/src/test/java/org/apache/shardingsphere/mode/metadata/MetaDataContextsFactoryTest.java:
##########
@@ -53,18 +70,57 @@ public final class MetaDataContextsFactoryTest {
@Mock
private DatabaseMetaDataPersistService databaseMetaDataPersistService;
-
+
+ @Mock
+ private ShardingSphereDatabase mockShardingSphereDb;
+
+ @Mock
+ private JDBCInstanceMetaData jdbcInstanceMetaData;
+
+ private final Properties properties = new Properties();
+
+ private final List<ShardingSphereRule> shardingSphereRules = new ArrayList<ShardingSphereRule>() {
+ {
+ add(new MockedRule());
Review Comment:
Please init collection in setUp method.
##########
shardingsphere-mode/shardingsphere-mode-core/src/test/java/org/apache/shardingsphere/mode/metadata/MetaDataContextsFactoryTest.java:
##########
@@ -53,18 +70,57 @@ public final class MetaDataContextsFactoryTest {
@Mock
private DatabaseMetaDataPersistService databaseMetaDataPersistService;
-
+
+ @Mock
+ private ShardingSphereDatabase mockShardingSphereDb;
+
+ @Mock
+ private JDBCInstanceMetaData jdbcInstanceMetaData;
+
+ private final Properties properties = new Properties();
+
+ private final List<ShardingSphereRule> shardingSphereRules = new ArrayList<ShardingSphereRule>() {
Review Comment:
Please use new LinkedList if we don't need get element by index.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org