[GitHub] [arrow] sweb commented on a change in pull request #8784: WIP: ARROW-10674: [Rust] Fix BigDecimal to be little endian; Add IPC Reader/Writer for Decimal type to allow integration tests

[GitBox <gi...@apache.org>]

sweb commented on a change in pull request #8784:
URL: https://github.com/apache/arrow/pull/8784#discussion_r534818902



##########
File path: rust/arrow/src/ipc/convert.rs
##########
@@ -97,6 +97,12 @@ pub fn fb_to_schema(fb: ipc::Schema) -> Schema {
     let len = c_fields.len();
     for i in 0..len {
         let c_field: ipc::Field = c_fields.get(i);
+        match c_field.type_type() {

Review comment:
       @alamb could you take another look at my attempt to add the unimplemented path for big endian?
   
   I am not happy with placing the check in `fb_to_schema` and would have preferred to put it in `get_data_type` but I found no way to pass on the endianness from the schema.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org