You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "yihua (via GitHub)" <gi...@apache.org> on 2025/05/23 03:15:46 UTC
[PR] [HUDI-9442] Improve key lookup in metadata table [hudi]
yihua opened a new pull request, #13348:
URL: https://github.com/apache/hudi/pull/13348
### Change Logs
_Describe context and summary for this change. Highlight if any code was copied._
### Impact
_Describe any public API or user-facing feature change or any performance impact._
### Risk level (write none, low medium or high below)
_If medium or high, explain what verification was done to mitigate the risks._
### Documentation Update
_Describe any necessary documentation update if there is any new feature, config, or user-facing change. If not, put "none"._
- _The config description must be updated if new configs are added or the default value of the configs are changed_
- _Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
ticket number here and follow the [instruction](https://hudi.apache.org/contribute/developer-setup#website) to make
changes to the website._
### Contributor's checklist
- [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
- [ ] Change Logs and Impact were stated clearly
- [ ] Adequate tests were added if applicable
- [ ] CI passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-9442] Improve key lookup in metadata table [hudi]
Posted by "voonhous (via GitHub) via commits" <co...@hudi.apache.org>.
voonhous closed pull request #13348: [HUDI-9442] Improve key lookup in metadata table
URL: https://github.com/apache/hudi/pull/13348
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-9442] Improve key lookup in metadata table [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13348:
URL: https://github.com/apache/hudi/pull/13348#issuecomment-2903129839
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7688b6cd877d9c588853305816f73ff945b50e39",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "7688b6cd877d9c588853305816f73ff945b50e39",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7688b6cd877d9c588853305816f73ff945b50e39 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-9442] Improve key lookup in metadata table [hudi]
Posted by "the-other-tim-brown (via GitHub)" <gi...@apache.org>.
the-other-tim-brown commented on code in PR #13348:
URL: https://github.com/apache/hudi/pull/13348#discussion_r2103723021
##########
hudi-common/src/main/java/org/apache/hudi/common/table/log/block/HoodieDataBlock.java:
##########
@@ -224,7 +224,12 @@ public final <T> ClosableIterator<HoodieRecord<T>> getRecordIterator(List<String
return allRecords;
}
- HashSet<String> keySet = new HashSet<>(keys);
+ // TODO(yihua): is this valid?
+
+ HashSet<String> keySet = new HashSet<>();
Review Comment:
If we can get back the records as a sorted iterator by key, then we can use the input keys iterator to filter in a more efficient way to comparing the head and popping instead of requiring to compute the hash of the key to check for presence in the set.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-9442] Improve key lookup in metadata table [hudi]
Posted by "the-other-tim-brown (via GitHub)" <gi...@apache.org>.
the-other-tim-brown commented on code in PR #13348:
URL: https://github.com/apache/hudi/pull/13348#discussion_r2103723244
##########
hudi-common/src/main/java/org/apache/hudi/common/table/log/block/HoodieDataBlock.java:
##########
@@ -224,7 +224,12 @@ public final <T> ClosableIterator<HoodieRecord<T>> getRecordIterator(List<String
return allRecords;
}
- HashSet<String> keySet = new HashSet<>(keys);
+ // TODO(yihua): is this valid?
+
+ HashSet<String> keySet = new HashSet<>();
+ while (keys.hasNext()) {
+ keySet.add(keys.next());
+ }
return FilteringIterator.getInstance(allRecords, keySet, fullKey, this::getRecordKey);
Review Comment:
Will this exit early after all keys are found if a set of keys is provided?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-9442] Improve key lookup in metadata table [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13348:
URL: https://github.com/apache/hudi/pull/13348#issuecomment-2903131956
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7688b6cd877d9c588853305816f73ff945b50e39",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=5666",
"triggerID" : "7688b6cd877d9c588853305816f73ff945b50e39",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7688b6cd877d9c588853305816f73ff945b50e39 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=5666)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-9442] Improve key lookup in metadata table [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13348:
URL: https://github.com/apache/hudi/pull/13348#issuecomment-2903209917
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7688b6cd877d9c588853305816f73ff945b50e39",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=5666",
"triggerID" : "7688b6cd877d9c588853305816f73ff945b50e39",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7688b6cd877d9c588853305816f73ff945b50e39 Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=5666)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-9442] Improve key lookup in metadata table [hudi]
Posted by "voonhous (via GitHub) via commits" <co...@hudi.apache.org>.
voonhous commented on PR #13348:
URL: https://github.com/apache/hudi/pull/13348#issuecomment-6700617313
Temporarily closing this PR while we debug a GitHub settings error on master (#20471); it will be reopened shortly, no action needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org