You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Niklas Nielsen <ni...@qni.dk> on 2014/04/04 02:37:47 UTC

Re: Review Request 18403: Added support for launching tasks by TaskInfo.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18403/
-----------------------------------------------------------

(Updated April 3, 2014, 5:37 p.m.)


Review request for mesos, Ian Downes and Vinod Kone.


Changes
-------

Rebased.


Bugs: MESOS-922
    https://issues.apache.org/jira/browse/MESOS-922


Repository: mesos-git


Description
-------

This patch delegates the choice of executor to the containerizer by removing executorInfo dependencies up until Containerizer::launch().
Containerizer::launch() now returns a future to the executor info that is being run and the slave creates the corresponding executor structure when launch completes.
This means message handling from the running executor to the slave in the interim where the executor structure has not created, need to be enqueued until executor is ready.


Diffs (updated)
-----

  src/slave/containerizer/containerizer.hpp d9ae326 
  src/slave/containerizer/mesos_containerizer.hpp ee1fd30 
  src/slave/containerizer/mesos_containerizer.cpp c819c97 
  src/slave/slave.hpp 15e23ce 
  src/slave/slave.cpp a356f5f 
  src/tests/containerizer.hpp a9f1531 
  src/tests/containerizer.cpp bfb9341 

Diff: https://reviews.apache.org/r/18403/diff/


Testing
-------

make check


Thanks,

Niklas Nielsen


Re: Review Request 18403: Added support for launching tasks by TaskInfo.

Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18403/
-----------------------------------------------------------

(Updated April 10, 2014, 12:19 p.m.)


Review request for mesos, Ian Downes and Vinod Kone.


Changes
-------

Added RR dependencies.


Bugs: MESOS-922
    https://issues.apache.org/jira/browse/MESOS-922


Repository: mesos-git


Description
-------

This patch delegates the choice of executor to the containerizer by removing executorInfo dependencies up until Containerizer::launch().
Containerizer::launch() now returns a future to the executor info that is being run and the slave creates the corresponding executor structure when launch completes.
This means message handling from the running executor to the slave in the interim where the executor structure has not created, need to be enqueued until executor is ready.


Diffs
-----

  src/slave/containerizer/containerizer.hpp d9ae326 
  src/slave/containerizer/mesos_containerizer.hpp ee1fd30 
  src/slave/containerizer/mesos_containerizer.cpp 1ce41d7 
  src/slave/slave.hpp 08f6005 
  src/slave/slave.cpp cddb241 
  src/tests/containerizer.hpp a9f1531 
  src/tests/containerizer.cpp bfb9341 
  src/tests/slave_recovery_tests.cpp 72b6d42 

Diff: https://reviews.apache.org/r/18403/diff/


Testing
-------

make check


Thanks,

Niklas Nielsen


Re: Review Request 18403: Added support for launching tasks by TaskInfo.

Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18403/
-----------------------------------------------------------

(Updated April 10, 2014, 12:17 p.m.)


Review request for mesos, Ian Downes and Vinod Kone.


Changes
-------

Rebased and ready for review.


Bugs: MESOS-922
    https://issues.apache.org/jira/browse/MESOS-922


Repository: mesos-git


Description
-------

This patch delegates the choice of executor to the containerizer by removing executorInfo dependencies up until Containerizer::launch().
Containerizer::launch() now returns a future to the executor info that is being run and the slave creates the corresponding executor structure when launch completes.
This means message handling from the running executor to the slave in the interim where the executor structure has not created, need to be enqueued until executor is ready.


Diffs (updated)
-----

  src/slave/containerizer/containerizer.hpp d9ae326 
  src/slave/containerizer/mesos_containerizer.hpp ee1fd30 
  src/slave/containerizer/mesos_containerizer.cpp 1ce41d7 
  src/slave/slave.hpp 08f6005 
  src/slave/slave.cpp cddb241 
  src/tests/containerizer.hpp a9f1531 
  src/tests/containerizer.cpp bfb9341 
  src/tests/slave_recovery_tests.cpp 72b6d42 

Diff: https://reviews.apache.org/r/18403/diff/


Testing
-------

make check


Thanks,

Niklas Nielsen


Re: Review Request 18403: Added support for launching tasks by TaskInfo.

Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18403/
-----------------------------------------------------------

(Updated April 8, 2014, 2:19 p.m.)


Review request for mesos, Ian Downes and Vinod Kone.


Changes
-------

Rebased.


Bugs: MESOS-922
    https://issues.apache.org/jira/browse/MESOS-922


Repository: mesos-git


Description
-------

This patch delegates the choice of executor to the containerizer by removing executorInfo dependencies up until Containerizer::launch().
Containerizer::launch() now returns a future to the executor info that is being run and the slave creates the corresponding executor structure when launch completes.
This means message handling from the running executor to the slave in the interim where the executor structure has not created, need to be enqueued until executor is ready.


Diffs (updated)
-----

  src/slave/containerizer/containerizer.hpp d9ae326 
  src/slave/containerizer/mesos_containerizer.hpp ee1fd30 
  src/slave/containerizer/mesos_containerizer.cpp c819c97 
  src/slave/slave.hpp 15e23ce 
  src/slave/slave.cpp a356f5f 
  src/tests/containerizer.hpp a9f1531 
  src/tests/containerizer.cpp bfb9341 

Diff: https://reviews.apache.org/r/18403/diff/


Testing
-------

make check


Thanks,

Niklas Nielsen