[jira] [Commented] (HDFS-9457) Datanode Logging Improvement

["Uma Maheswara Rao G (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HDFS-9457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15025065#comment-15025065 ] 

Uma Maheswara Rao G commented on HDFS-9457:
-------------------------------------------

{code}
   } else {
+            LOG.trace("getBlockLocalPathInfo for block=null returning null");
{code}
I think you should keep original code for this log. Logging block details would be useful info. block might not be be null but blockPath info is null.

Please follow right coding format. Indentation should be 2, not 4.

> Datanode Logging Improvement
> ----------------------------
>
>                 Key: HDFS-9457
>                 URL: https://issues.apache.org/jira/browse/HDFS-9457
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: datanode
>    Affects Versions: 3.0.0, 2.7.0
>            Reporter: BELUGA BEHR
>            Priority: Trivial
>         Attachments: Logging.diff
>
>
> Please accept my patch for some minor clean-up of logging. Patch is against 3.0.0 but applies to previous versions as well.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)