You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@polaris.apache.org by "adutra (via GitHub)" <gi...@apache.org> on 2025/10/02 13:16:05 UTC
[PR] Deprecate legacy management endpoints for removal [polaris]
adutra opened a new pull request, #2749:
URL: https://github.com/apache/polaris/pull/2749
Corresponding removal PR: #2276
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Deprecate legacy management endpoints for removal [polaris]
Posted by "dimas-b (via GitHub)" <gi...@apache.org>.
dimas-b commented on code in PR #2749:
URL: https://github.com/apache/polaris/pull/2749#discussion_r2399207153
##########
CHANGELOG.md:
##########
@@ -34,6 +34,9 @@ request adding CHANGELOG notes for breaking (!) changes and possibly other secti
- Amazon RDS plugin enabled, this allows polaris to connect to AWS Aurora PostgreSQL using IAM authentication.
- The EclipseLink Persistence implementation has been deprecated since 1.0.0 and will be completely removed
in 1.3.0 or in 2.0.0 (whichever happens earlier).
+- The legacy management endpoints at `/metrics` and `/healthcheck` have been deprecated in 1.2.0 and will be
Review Comment:
nit: I wonder if it might fit better in the `Deprecations` section 🤔 Upgrades are not really affected until #2276 is merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Deprecate legacy management endpoints for removal [polaris]
Posted by "adutra (via GitHub)" <gi...@apache.org>.
adutra commented on code in PR #2749:
URL: https://github.com/apache/polaris/pull/2749#discussion_r2399424320
##########
CHANGELOG.md:
##########
@@ -34,6 +34,9 @@ request adding CHANGELOG notes for breaking (!) changes and possibly other secti
- Amazon RDS plugin enabled, this allows polaris to connect to AWS Aurora PostgreSQL using IAM authentication.
- The EclipseLink Persistence implementation has been deprecated since 1.0.0 and will be completely removed
in 1.3.0 or in 2.0.0 (whichever happens earlier).
+- The legacy management endpoints at `/metrics` and `/healthcheck` have been deprecated in 1.2.0 and will be
Review Comment:
Oh my bad, I saw the deprecation notice above and just added mine below.
Let's move both to the right section.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Deprecate legacy management endpoints for removal [polaris]
Posted by "dimas-b (via GitHub)" <gi...@apache.org>.
dimas-b commented on code in PR #2749:
URL: https://github.com/apache/polaris/pull/2749#discussion_r2402895845
##########
CHANGELOG.md:
##########
@@ -53,6 +51,11 @@ request adding CHANGELOG notes for breaking (!) changes and possibly other secti
### Deprecations
* The property `polaris.active-roles-provider.type` is deprecated and has no effect anymore.
+- The EclipseLink Persistence implementation has been deprecated since 1.0.0 and will be completely removed
+ in 1.3.0 or in 2.0.0 (whichever happens earlier).
+- The legacy management endpoints at `/metrics` and `/healthcheck` have been deprecated in 1.2.0 and will be
+ completely removed in 1.3.0 or in 2.0.0 (whichever happens earlier). Please use the standard management
Review Comment:
As for the number of releases to "wait", I'm not sure it helps users so much. People who upgrade often will be able to deal with changes. People who do not upgrade to avoid changes, will be suffering from lack of evolution / bug fixes in EL, so it's not a sound strategy IMHO.
As for the endpoints, as I commented in some other thread, it's really a backend change. It only affects the "devops" personas and can be applied holistically without any visible client-side effects... so again I do not see a strong reason to defer this change.
... happy to discuss on `dev` ML too :slightly_smiling_face:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Deprecate legacy management endpoints for removal [polaris]
Posted by "dimas-b (via GitHub)" <gi...@apache.org>.
dimas-b commented on code in PR #2749:
URL: https://github.com/apache/polaris/pull/2749#discussion_r2402895845
##########
CHANGELOG.md:
##########
@@ -53,6 +51,11 @@ request adding CHANGELOG notes for breaking (!) changes and possibly other secti
### Deprecations
* The property `polaris.active-roles-provider.type` is deprecated and has no effect anymore.
+- The EclipseLink Persistence implementation has been deprecated since 1.0.0 and will be completely removed
+ in 1.3.0 or in 2.0.0 (whichever happens earlier).
+- The legacy management endpoints at `/metrics` and `/healthcheck` have been deprecated in 1.2.0 and will be
+ completely removed in 1.3.0 or in 2.0.0 (whichever happens earlier). Please use the standard management
Review Comment:
As for the number of releases to "wait", I'm not sure it helps uses so much. People who upgrade often will be able to deal with changes. People who do not upgrade to avoid changes, will be suffering from lack of evolution / bug fixes in EL, so it's not a sound strategy IMHO.
As for the endpoints, as I commented in some other thread, it's really a backend change. It only affects the "devops" personas and can be applied holistically without any visible client-side effects... so again I do not see a strong reason to defer this change.
... happy to discuss on `dev` ML too :slightly_smiling_face:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Deprecate legacy management endpoints for removal [polaris]
Posted by "singhpk234 (via GitHub)" <gi...@apache.org>.
singhpk234 commented on code in PR #2749:
URL: https://github.com/apache/polaris/pull/2749#discussion_r2400758219
##########
CHANGELOG.md:
##########
@@ -53,6 +51,11 @@ request adding CHANGELOG notes for breaking (!) changes and possibly other secti
### Deprecations
* The property `polaris.active-roles-provider.type` is deprecated and has no effect anymore.
+- The EclipseLink Persistence implementation has been deprecated since 1.0.0 and will be completely removed
+ in 1.3.0 or in 2.0.0 (whichever happens earlier).
+- The legacy management endpoints at `/metrics` and `/healthcheck` have been deprecated in 1.2.0 and will be
+ completely removed in 1.3.0 or in 2.0.0 (whichever happens earlier). Please use the standard management
Review Comment:
> completely removed in 1.3.0 or in 2.0.0 (whichever happens earlier)
do we wanna give it 1 or 2 more releases for complete removal, 1.5.0 or in 2.0.0 (whichever happens earlier)
I am fine with marking the APIs as forRemoval
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Deprecate legacy management endpoints for removal [polaris]
Posted by "singhpk234 (via GitHub)" <gi...@apache.org>.
singhpk234 commented on code in PR #2749:
URL: https://github.com/apache/polaris/pull/2749#discussion_r2400758219
##########
CHANGELOG.md:
##########
@@ -53,6 +51,11 @@ request adding CHANGELOG notes for breaking (!) changes and possibly other secti
### Deprecations
* The property `polaris.active-roles-provider.type` is deprecated and has no effect anymore.
+- The EclipseLink Persistence implementation has been deprecated since 1.0.0 and will be completely removed
+ in 1.3.0 or in 2.0.0 (whichever happens earlier).
+- The legacy management endpoints at `/metrics` and `/healthcheck` have been deprecated in 1.2.0 and will be
+ completely removed in 1.3.0 or in 2.0.0 (whichever happens earlier). Please use the standard management
Review Comment:
> completely removed in 1.3.0 or in 2.0.0 (whichever happens earlier)
do we wanna give it 1 or 2 more releases for complete removal, 1.5.0 or in 2.0.0 (whichever happens earlier)
I am totally fine with marking these APIs as forRemoval
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Deprecate legacy management endpoints for removal [polaris]
Posted by "jbonofre (via GitHub)" <gi...@apache.org>.
jbonofre commented on code in PR #2749:
URL: https://github.com/apache/polaris/pull/2749#discussion_r2400949313
##########
CHANGELOG.md:
##########
@@ -53,6 +51,11 @@ request adding CHANGELOG notes for breaking (!) changes and possibly other secti
### Deprecations
* The property `polaris.active-roles-provider.type` is deprecated and has no effect anymore.
+- The EclipseLink Persistence implementation has been deprecated since 1.0.0 and will be completely removed
+ in 1.3.0 or in 2.0.0 (whichever happens earlier).
+- The legacy management endpoints at `/metrics` and `/healthcheck` have been deprecated in 1.2.0 and will be
+ completely removed in 1.3.0 or in 2.0.0 (whichever happens earlier). Please use the standard management
Review Comment:
I would propose to flag to removal now, and the actual removal can happen in Polaris 2.0.0 (I don't see problem to release 2.0.0 soon 😄 ).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Deprecate legacy management endpoints for removal [polaris]
Posted by "dimas-b (via GitHub)" <gi...@apache.org>.
dimas-b commented on code in PR #2749:
URL: https://github.com/apache/polaris/pull/2749#discussion_r2399545913
##########
CHANGELOG.md:
##########
@@ -34,6 +34,9 @@ request adding CHANGELOG notes for breaking (!) changes and possibly other secti
- Amazon RDS plugin enabled, this allows polaris to connect to AWS Aurora PostgreSQL using IAM authentication.
- The EclipseLink Persistence implementation has been deprecated since 1.0.0 and will be completely removed
in 1.3.0 or in 2.0.0 (whichever happens earlier).
+- The legacy management endpoints at `/metrics` and `/healthcheck` have been deprecated in 1.2.0 and will be
Review Comment:
Good catch about EL - thx for fixing that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Deprecate legacy management endpoints for removal [polaris]
Posted by "dimas-b (via GitHub)" <gi...@apache.org>.
dimas-b merged PR #2749:
URL: https://github.com/apache/polaris/pull/2749
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Deprecate legacy management endpoints for removal [polaris]
Posted by "dimas-b (via GitHub)" <gi...@apache.org>.
dimas-b commented on code in PR #2749:
URL: https://github.com/apache/polaris/pull/2749#discussion_r2402884192
##########
CHANGELOG.md:
##########
@@ -53,6 +51,11 @@ request adding CHANGELOG notes for breaking (!) changes and possibly other secti
### Deprecations
* The property `polaris.active-roles-provider.type` is deprecated and has no effect anymore.
+- The EclipseLink Persistence implementation has been deprecated since 1.0.0 and will be completely removed
+ in 1.3.0 or in 2.0.0 (whichever happens earlier).
+- The legacy management endpoints at `/metrics` and `/healthcheck` have been deprecated in 1.2.0 and will be
+ completely removed in 1.3.0 or in 2.0.0 (whichever happens earlier). Please use the standard management
Review Comment:
Postponing removal should be transparent for end users (even if previously said "removing in 1.3 :sweat_smile: ).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Deprecate legacy management endpoints for removal [polaris]
Posted by "dimas-b (via GitHub)" <gi...@apache.org>.
dimas-b commented on code in PR #2749:
URL: https://github.com/apache/polaris/pull/2749#discussion_r2402901821
##########
CHANGELOG.md:
##########
@@ -53,6 +51,11 @@ request adding CHANGELOG notes for breaking (!) changes and possibly other secti
### Deprecations
* The property `polaris.active-roles-provider.type` is deprecated and has no effect anymore.
+- The EclipseLink Persistence implementation has been deprecated since 1.0.0 and will be completely removed
+ in 1.3.0 or in 2.0.0 (whichever happens earlier).
+- The legacy management endpoints at `/metrics` and `/healthcheck` have been deprecated in 1.2.0 and will be
+ completely removed in 1.3.0 or in 2.0.0 (whichever happens earlier). Please use the standard management
Review Comment:
... and I'm in favour of making 2.0 soon :wink:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org